commented out code triggers failure

[frantzypants]

When you upload a theme that has commented out code that contains outdated helpers, e.g.

<!-- <header class="main-header {{#if @blog.cover}}" 
style="background-image: url({{@blog.cover}}){{else}}no-cover{{/if}}"> -->

gscan will still assume the theme is incompatible until you've made the change to the code in the comment. I understand it's important to have up-to-date helpers/code, but given it's commented out shouldn't it still pass or be able to activate on a blog - and this be presented as a warning instead?

[kirrg001]

Thanks @frantzypants!

Yeah agree, GScan shouldn't detect commented out code or show a warning instead.

[kevinansfield]

I think it will be important to distinguish between HTML comments and Handlebars comments.

The above code has HTML comments so the handlebars code is still being run and has a chance of causing errors. I imagine the comment detecting rules would need to be per-helper to determine if it's "kind of ok" or "definitely not ok" for the handlebars code to be run within a HTML comment?