Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gscan usage thoughts / suggestion #122

Open
frantzypants opened this issue Jul 26, 2018 · 1 comment
Open

gscan usage thoughts / suggestion #122

frantzypants opened this issue Jul 26, 2018 · 1 comment

Comments

@frantzypants
Copy link

Having used gscan over 100+ times now, I personally have found it difficult to quickly interpret what needs to be changed on a theme. The way we present the information is currently to show the old helper, and what it was replaced with, and then you have to click a button to see what files need to be updated… this is tedious.

I’m not sure what the best solution is, or if it’s worth changing, but for me personally I’d prefer to see each file that needs to be updated, and everything that needs to be updated on THAT file.

In the beginning, it was super annoying to see that {{image}} was replaced with {{profile_image}} for example on the author.hbs in one section of gscan’s results - then I’d go make that change, save the file, and move down the list….only to find that - oh crap - I need to go open up author.hbs AGAIN and change something else + save, etc.

I’m to the point now where I know what needs fixed, but before it was just frustrating to open file -> make change -> save -> look at gscan results -> open same file again -> make change - save -> etc.

@kirrg001
Copy link
Contributor

Thanks @frantzypants!

I’m not sure what the best solution is, or if it’s worth changing, but for me personally I’d prefer to see each file that needs to be updated, and everything that needs to be updated on THAT file.

I agree to that 👍Maybe it would be cool to have two different ways of outputting the report. Once ordered by rules and once ordered by theme files.

kirrg001 added a commit to kirrg001/gscan that referenced this issue Aug 8, 2018
refs TryGhost#122

- gscan.format accepts a new flag to return a different format
  - sort by errors & warnings files
- @todo: sort recommendations
kirrg001 added a commit to kirrg001/gscan that referenced this issue Aug 8, 2018
refs TryGhost#122

- gscan.format accepts a new flag to return a different format
  - sort by errors & warnings files
- @todo: sort recommendations
kirrg001 added a commit to kirrg001/gscan that referenced this issue Aug 9, 2018
refs TryGhost#122

- gscan.format accepts a new flag to return a different format
  - sort by errors & warnings files
- @todo: sort recommendations
kirrg001 added a commit to kirrg001/gscan that referenced this issue Aug 9, 2018
refs TryGhost#122

- gscan.format accepts a new flag to return a different format
  - sort by errors & warnings files
- it's currently hard to sort the pased rules, because no rule pushed the file reference
  - we should raise an issue
kirrg001 added a commit to kirrg001/gscan that referenced this issue Aug 9, 2018
refs TryGhost#122

- gscan.format accepts a new flag to return a different format
  - sort by errors & warnings files
- it's currently hard to sort the pased rules, because no rule pushed the file reference
  - we should raise an issue
kirrg001 added a commit to kirrg001/gscan that referenced this issue Aug 9, 2018
refs TryGhost#122

- `gscan.format` now accepts a new option to return a different format
  - sort by errors & warnings files
  - sort by rules by default
- it's currently hard to sort the pased rules, because no rule pushed the file reference
  - too much effort
kirrg001 added a commit to kirrg001/gscan that referenced this issue Aug 9, 2018
refs TryGhost#122

- `gscan.format` now accepts a new option to return a different format
  - sort by errors & warnings files (sortByFiles: true)
  - sort by rules by default
- it's currently hard to sort the passed rules, because no rule is pushed with the file reference
  - too much effort for no usage
kirrg001 added a commit that referenced this issue Aug 9, 2018
refs #122

- `gscan.format` now accepts a new option to return a different format
  - sort by errors & warnings files (sortByFiles: true)
  - sort by rules by default
- it's currently hard to sort the passed rules, because no rule is pushed with the file reference
  - too much effort for no usage
kirrg001 added a commit that referenced this issue Aug 14, 2018
refs #122

- `gscan.format` now accepts a new option to return a different format
  - sort by errors & warnings files (sortByFiles: true)
  - sort by rules by default
- it's currently hard to sort the passed rules, because no rule is pushed with the file reference
  - too much effort for no usage
kirrg001 added a commit that referenced this issue Aug 14, 2018
refs #122

- `gscan.format` now accepts a new option to return a different format
  - sort by errors & warnings files (sortByFiles: true)
  - sort by rules by default
- it's currently hard to sort the passed rules, because no rule is pushed with the file reference
  - too much effort for no usage
kirrg001 added a commit that referenced this issue Aug 14, 2018
refs #122

- `gscan.format` now accepts a new option to return a different format
  - sort by errors & warnings files (sortByFiles: true)
  - sort by rules by default
- it's currently hard to sort the passed rules, because no rule is pushed with the file reference
  - too much effort for no usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants