Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GScan should validate image_sizes config/use in a theme #173

Open
allouis opened this issue Jan 2, 2019 · 0 comments
Open

GScan should validate image_sizes config/use in a theme #173

allouis opened this issue Jan 2, 2019 · 0 comments
Labels
enhancement

Comments

@allouis
Copy link
Contributor

allouis commented Jan 2, 2019

I guess we'd want to:

  • validate that width/height are numbers?
  • validate any use of the img_url helper either omits the size or the size exists.

@JohnONolan I've moved this out from so that we can close it TryGhost/Ghost#10181 - you might be able to add some more things that we could/should validate?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@allouis