Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixed "name" property in package.json is not supported? #264

Open
stcherenkov opened this issue Oct 21, 2019 · 4 comments
Open

Prefixed "name" property in package.json is not supported? #264

stcherenkov opened this issue Oct 21, 2019 · 4 comments
Labels

Comments

@stcherenkov
Copy link

Hello!

When I name my theme @org/foo in package.json and check it with GScan, I get:

  • Error: package.json property "name" must be hyphenated

Ghost really does not support package name with organization prefix for themes? Or is it GScan-only issue?

@naz
Copy link
Member

naz commented Oct 21, 2019

Hi @stcherenkov! This is a gscan issue and after trying to activate some themes locally haven't found any issues with such naming. It's probably up for discussion if we should allow namespacing in theme naming as the current one has been established years ago ⏳

@stcherenkov
Copy link
Author

Well, it looks like namespaces are a solid part of npm ecosystem now. This npm feature is also getting wide adoption by companies for private packages or publicly sourced packages with primary use inside company.

There is also a nice feature for Ghost theme developers – to be identified as an author of multiple themes by owning a named scope.

@mindsers
Copy link

Facing the same issue. Glad to see that it's only a GScan "issue".

@ErisDS
Copy link
Member

ErisDS commented Apr 8, 2020

We should fix this, but it needs a bit of a check to make sure that fixing it doesn't result in any breakages in e.g. Ghost Admin UI or theme handling code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants