Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially misleading warning for {{ @labs.members }} #396

Open
SingingTree opened this issue Aug 13, 2021 · 0 comments
Open

Potentially misleading warning for {{ @labs.members }} #396

SingingTree opened this issue Aug 13, 2021 · 0 comments

Comments

@SingingTree
Copy link

#373 added a warning for {{ @labs.members }} usage. The warning states

The {{@labs.members}} helper will always return true in Ghost v4 and will be removed from Ghost v5, at which point it will return null and evaluate to false.Find more information about the @labs property here.

However, the current docs state

The existing {{@labs.members}} flag will return true by default, and false if the Subscription access setting is set to Nobody.

Which appears to be correct in testing.

It sounds like the intention is still to remove the helper and replace it with something else. Until the replacement exists, {{ @labs.members }} seems one of the better ways to conditionally show things like subscribe buttons. Is there any value in changing the warning to reflect the correct functionality of the helper, whilst retaining the deprecation warning (assuming the helper is still being deprecated)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant