Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team 4 and 8 Sprint 4 Feature Ticket - Player Attack #384

Open
5 tasks done
Tracked by #425 ...
enmmjc opened this issue Oct 8, 2021 · 10 comments
Open
5 tasks done
Tracked by #425 ...

Team 4 and 8 Sprint 4 Feature Ticket - Player Attack #384

enmmjc opened this issue Oct 8, 2021 · 10 comments

Comments

@enmmjc
Copy link
Contributor

enmmjc commented Oct 8, 2021

Description

This feature is dedicated to the integration and attack functionality of the protagonist. We need to take the following insights into consideration...

  • Obstacles can only be attacked remotely
  • How will the attack be performed aesthetically by the MPC.
  • Where to collect the weapons? From the start of the game or as item pickups?
    Therefore, it is necessary to discuss with Team 8 to determine the different images of the main character during the attack process and how it would attack. --- for this, team 5 will join us, to give the initial numbers of flame attack

Sub Features & Components

  • Weapons sprites - The sprites of different kinds of weapons to be used in the game. NOTE: Remote weapons.
  • Player attack action image/animation integration.

Examples

  • The player should be able to attack obstacles at a particular distance.

Milestones

  • Code implementation of attack launch (team 8)
  • Particle effects of flame (team 8)
  • Assert design when the character is attacking (holding a gun barrel) (team 4)
  • Code implementation of flame in inventory (team 5)
  • Design flame cannonballs for inventory (team 5)

Test and evaluation deadline (Oct. 18)

Members

@enmmjc enmmjc added this to the Sprint 4 milestone Oct 8, 2021
@enmmjc enmmjc added this to Backlog in Feature Board via automation Oct 8, 2021
@lisslulay
Copy link
Contributor

lisslulay commented Oct 8, 2021

Hi, this is team8. We think that if the player needs to pick up the weapon to attack, this needs to cooperate with team1.

The following weapons refer to things that can be thrown or shot separately from the characters.

Code part:

Team 8 is willing to be responsible for the code implementation of the weapon fired when the character presses the key. This includes the direction and speed of the throw and handling collisions of weapons and obstacles.

The part of the code we expect you to complete is: When the player (with a weapon) presses the attack button, an attack event can be triggered. If you want to trigger the event after picking up the weapon, this part should be discussed with the team1.

We will set up the listener to complete the launch of the weapon and follow-up work.

Design part:

We can use particle special effects as attack effects, which will look better visually. This can be designed by team8. Our current idea is that the character emits something like a flame
image

If your group agrees with our ideas, please reply to me. I will start this part of the work as soon as possible.

@lisslulay
Copy link
Contributor

Create branch player-attack, We can implement the code in this branch

@ThatTechedGuy
Copy link
Contributor

Hi, @lisslulay @enmmjc @kprohith I checked the video posted in #team-4 channel on Discord, that Jason was throwing something at the obstacles and damaging them. Great job guys! Although, the necessary amends have to be made to the game story as well. Maybe one or two lines about how Jason defends himself by attacking the obstacles. Please make the necessary suggestions in #373. We are currently working on the final chapter of the game story, so stuff about Jason's attacks can go there as well. cc: @Butcanudothis @addiii4

@lisslulay
Copy link
Contributor

lisslulay commented Oct 9, 2021

hi, in the current version, the player can launch numerous attacks, which basically avoids all obstacles on the ground.
In order to limit the number of attacks by the characters, we may need to cooperate with team5, so that the artillery in the inventory is limited.

@lisslulay
Copy link
Contributor

Hi, @lisslulay @enmmjc @kprohith I checked the video posted in #team-4 channel on Discord, that Jason was throwing something at the obstacles and damaging them. Great job guys! Although, the necessary amends have to be made to the game story as well. Maybe one or two lines about how Jason defends himself by attacking the obstacles. Please make the necessary suggestions in #373. We are currently working on the final chapter of the game story, so stuff about Jason's attacks can go there as well. cc: @Butcanudothis @addiii4

We haven't decided on the specific attack method of the character. After we discuss it, we will go back to your ticket and comment.

@lisslulay lisslulay self-assigned this Oct 9, 2021
lisslulay added a commit that referenced this issue Oct 9, 2021
lisslulay added a commit that referenced this issue Oct 9, 2021
lisslulay added a commit that referenced this issue Oct 9, 2021
@lisslulay lisslulay changed the title Team 4 Sprint 4 Feature Ticket 2: Player Attack Player Attack Oct 10, 2021
@lisslulay
Copy link
Contributor

Change the title because this feature needs to be completed by multiple teams.

@yu-ang-zhang
Copy link
Contributor

now the flame is showing beside recycle system in item bar, we made its initial number is 9

@uqtnieva uqtnieva moved this from Backlog to Approved in Feature Board Oct 10, 2021
@lisslulay lisslulay moved this from Approved to In Progress in Feature Board Oct 11, 2021
@enmmjc enmmjc changed the title Player Attack Team 4, 5, 8 Sprint 4 Feature Ticket - Player Attack Oct 12, 2021
@RecklessPotcover
Copy link
Contributor

*Completed two remote attack frames for gold-6 attire:

main_player_attack_1
main_player_attack_2

@lisslulay
Copy link
Contributor

lisslulay commented Oct 13, 2021

@RecklessPotcover
Good job! You guys can add animation to the characters and check the effect.
We are a little worried that the character is too small and the gun will be smaller. Anyway, it is always wise to put it into the game to check. 😂

@lisslulay lisslulay linked a pull request Oct 13, 2021 that will close this issue
@lisslulay lisslulay removed a link to a pull request Oct 13, 2021
@lisslulay
Copy link
Contributor

lisslulay commented Oct 16, 2021

The new attack particle special effect has been uploaded.
attack

@enmmjc enmmjc changed the title Team 4, 5, 8 Sprint 4 Feature Ticket - Player Attack Team 4 and 8 Sprint 4 Feature Ticket - Player Attack Oct 18, 2021
@kprohith kprohith moved this from In Progress to Done in Feature Board Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment