Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timer bug and Upgrade timer (Team 5) #62

Open
3 tasks
XUEHUANG521 opened this issue Sep 14, 2021 · 7 comments
Open
3 tasks

Fix timer bug and Upgrade timer (Team 5) #62

XUEHUANG521 opened this issue Sep 14, 2021 · 7 comments
Assignees
Labels
Game loop Sprint 2 The second sprint for the project Task Team 5

Comments

@XUEHUANG521
Copy link
Contributor

Description

Task: fix timer bug and upgrade timer
Feature: #40

Fix timer bug which can't trigger time lose condition and quit the game accidentally.
in addition, work with designers to design animation for the timer and change timer display based on suggestion from Copy of Features "List of features for Sprint 2
" section.

Dependencies

  • N/A

Milestones

  • Fix timer bug (10/09/2021).
  • upgrade timer display (12/09/2021).
  • implement timer animation (17/09/2021).

Documentation

Game Transition Loop

Members

@XUEHUANG521 XUEHUANG521 added Game loop Team 5 Task Sprint 2 The second sprint for the project labels Sep 14, 2021
@XUEHUANG521 XUEHUANG521 self-assigned this Sep 14, 2021
@pranaypremdas
Copy link
Contributor

Hi, not sure if this is a timer issue or not, but it seems to be that the interactions don't work when there are less than 5 seconds left.

@XUEHUANG521
Copy link
Contributor Author

Hi, not sure if this is a timer issue or not, but it seems to be that the interactions don't work when there are less than 5 seconds left.
What do you mean?

@pranaypremdas
Copy link
Contributor

Hi, not sure if this is a timer issue or not, but it seems to be that the interactions don't work when there are less than 5 seconds left.
What do you mean?

Well I think that there might be an issue with the timer interfering with the interactions. I could be wrong. But I have done the testing multiple times. It seems to be that after 5 seconds I can't interact with the TV or Door that I have created. So if there is anything that you think could be affecting it let me know. I am currently working on fixing it so if you think it is not an issue with the timer then don't worry.

@XUEHUANG521
Copy link
Contributor Author

Hi, not sure if this is a timer issue or not, but it seems to be that the interactions don't work when there are less than 5 seconds left.
What do you mean?

Well I think that there might be an issue with the timer interfering with the interactions. I could be wrong. But I have done the testing multiple times. It seems to be that after 5 seconds I can't interact with the TV or Door that I have created. So if there is anything that you think could be affecting it let me know. I am currently working on fixing it so if you think it is not an issue with the timer then don't worry.

Actually, i have upgrade the timer based on feedback, which it would be more realistic, timer would start at 8 pm to 2 am. when time reach to 2 am, it would trigger the lose condition, as I still need half of day to modify this, i didn't push it to the branch yet. it would be there tomorrow morning.

@pranaypremdas
Copy link
Contributor

Actually, i have upgrade the timer based on feedback, which it would be more realistic, timer would start at 8 pm to 2 am. when time reach to 2 am, it would trigger the lose condition, as I still need half of day to modify this, i didn't push it to the branch yet. it would be there tomorrow morning.

I fixed it. Its not related to the timer. Its to do with the new collision detection system.

@XUEHUANG521
Copy link
Contributor Author

Bug fixed

@tweeeb
Copy link
Contributor

tweeeb commented Oct 6, 2021

Hi! This is Treffery from team 2, just commenting that there is another bug with the timer, when triggered the time out lose condition (i.e. when the timer hits 2:00), the game crashes due to a null pointer exception in main.

@tweeeb tweeeb reopened this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game loop Sprint 2 The second sprint for the project Task Team 5
Projects
None yet
Development

No branches or pull requests

3 participants