Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Privacy] Time limit on retaining beacons for bfcache'd pages #3

Open
caraitto opened this issue Jun 21, 2022 · 34 comments · Fixed by #15
Open

[Privacy] Time limit on retaining beacons for bfcache'd pages #3

caraitto opened this issue Jun 21, 2022 · 34 comments · Fixed by #15

Comments

@caraitto
Copy link
Contributor

My understanding is that with the Declarative Beacon API, if a page is kept in the bfcache for an extended period of time, it's still eligible to send the beacon once the page is evicted from the bfcache, which might be a long time after the user has navigated away from the page.

Would it be possible to instead send the beacon for bfcache'd pages after they've been in the bfcache for a minute or so? I think the page would want to check when waking from the bfcache to see if the beacon was already sent or not (by checking the state field of the beacon from the explainer) -- if it's already sent, the page may want to create a new beacon (at its choice).

@caraitto
Copy link
Contributor Author

Hi, friendly ping?

@clelland
Copy link
Collaborator

I think that this is what the pageHideTimeout setting is for -- pageHide is emitted when the page enters the bfcache, and that should start a timer for any beacons with pageHideTimeout set. If they aren't restored from cache by the time that timer expires, they will be sent at that time (rather than waiting until eviction)

@caraitto
Copy link
Contributor Author

The explainer says:

For frozen pages that are never unfrozen, this should happen either when the frozen page is removed from memory (BFCache eviction), or after a developer-specified timeout (using the 'pageHideTimeout' described below).

I think the idea is the beacon is sent for whichever event happens first of the two? But, if the site doesn't set pageHideTimeout, what is the behavior? Also, can pageHideTimeout be arbitrarily large?

The pageHideTimeout behavior sounds like the behavior we want, but I think the explainer and spec should be updated to give default and maximum pageHideTimeout values to prevent sending beacons at bfcache eviction at some point long after the user has left the page.

@mingyc
Copy link
Collaborator

mingyc commented Jun 28, 2022

I think the idea is the beacon is sent for whichever event happens first of the two?

Yes

But, if the site doesn't set pageHideTimeout, what is the behavior?

The default behavior is specified in the pageHideTimeout section, i.e. If this is null when the page is hidden, the beacon will be sent on document discard (including eviction from the BFCache)

Also, can pageHideTimeout be arbitrarily large?

It is possible as there is currently no maximum.

maximum pageHideTimeout values to prevent sending beacons at bfcache eviction at some point long after the user has left the page.

I think users should specify pageHideTimeout if they don't want to wait too long.

@caraitto
Copy link
Contributor Author

I think users should specify pageHideTimeout if they don't want to wait too long.

I agree, but for privacy, I think there should be a limit (imposed by the browser) on how long this duration can be that the web content cannot override. I think the spec and explainer should require such limits.

@clelland
Copy link
Collaborator

That sounds like a second issue, @caraitto (but correct me if I'm wrong)

The first issue I see is one of developer ergonomics. In order to have beacons sent in a timely manner, there should be a way to ensure that they are sent a short time after entering the bfcache. We have that, and it's pageHideTimeout. My understanding is that if that is set, and a page enters the cache, then one of three things can happen: (Whichever happens first wins)

  • If the page is restored from the cache, the beacon is cancelled.
  • If the page is evicted from the cache (which browsers will do after a short timeout; the cache is fairly short-lived in current imlementations), then the beacon is sent.
  • If the page is still in the cache after pageHideTimeout ms, then the beacon will be sent (and will be in a 'sent' state if the page is subsequently restored)

The second issue you raise is a privacy concern, which I think is motivated by a "what if browser's didn't do that" question around the second point above. Currently there is a time limit set by browsers, which web content can't override (Chrome, for instance, has a 3 minute timer). But what if future browsers keep pages in the bfcache for an arbitrarily long time, and also developers don't choose to set a timeout on their own. Should we protect developers from that situation?

I feel that there could be an implementation note, certainly, that there should be some reasonable limit, if the user agent is capable of retaining cache entries indefinitely, and it warrants a section in the privacy section of the spec. I don't know if there's sufficient alignment between cache implementations to specify yet exactly what a hard limit needs to be.

@caraitto
Copy link
Contributor Author

I feel that there could be an implementation note, certainly, that there should be some reasonable limit, if the user agent is capable of retaining cache entries indefinitely, and it warrants a section in the privacy section of the spec.

Yep, I think that's basically what I'd like to see -- I'll go ahead and send a PR (#5). I think 3 minutes might be OK, but I'd be less comfortable if it was over 10 minutes.

@mingyc
Copy link
Collaborator

mingyc commented Aug 1, 2022

This was re-discussed in #16 (comment):

  • @philipwalton suggests that there are use cases longer than 10 minutes timeout
  • @fergald mentions Mozilla's bfcache timeout is 45 minutes.

Maybe we should re-consider how long timeout limit should be.

mingyc added a commit that referenced this issue Sep 14, 2022
Update Privacy section to clarify why beacon needs to be stopped when network changes (#27 #28)

Also added links to related privacy discussions: #3, #27, #30, #34
Updated beacon TTL to 30min per suggestion in #16 (comment)
caraitto added a commit to caraitto/docs that referenced this issue Oct 11, 2022
Also, add the privacy rationale for needing a low limit.

See also WICG#3.
@caraitto
Copy link
Contributor Author

@fergald Continuing the discussion from #16 (comment) (seems like this is a better place to discuss):

I discussed the idea of allowing sending beacons after 10 minutes from the point a page entered the bfcache with some other Privacy / Security reviewers -- I think we're OK with this, even with frames (where the behavior introduced by beacons may not be polyfilable), because the frame site (say maps.company.com) is already able to transmit during network changes via the other tab (this is part of the general IP privacy problem).

We're also OK using eTLD+1 / First Party Sets for determining if another tab / frame is open from the same-site.

I'll update my PR -- my understanding is that if there isn't another site open with the page content, that the beacon will need to be sent within 10 minutes of entering the bfcache -- is that OK? If not, we'd need further discussion, since the privacy-wise, the API would be more like background sync (which requires a permission) -- but my understanding is that we're OK limiting to 10 minutes in the event that no other tab has a frame with the same site?

@mingyc
Copy link
Collaborator

mingyc commented Oct 19, 2022

  1. If we lower the limit down to 10 minutes, some behavior of the API, i.e. sending on page/frame discard, will not be able to work on the browser that has longer bfcache limit (e.g. Mozilla is 45 minutes).

if there isn't another site open with the page content, that the beacon will need to be sent within 10 minutes of entering the bfcache -- is that OK? If not, we'd need further discussion, since the privacy-wise, the API would be more like background sync (which requires a permission)

  1. Current design does respect background sync permission: Post-unload beacons are not sent if background sync is disabled for a site.
  2. (Trying to summarize) After PR Lower the bfcache limit to 10 min. #41, for a beacon to live beyond the point of pagehide event:
    • Background Sync permission needs to be granted. Otherwise nothing will be sent and all beacons get dropped.
    • network must be the same (currently not able to ensure this, so the Chrome implementation just sends out on pagehide).
    • it has to be < 10 minutes after pagehide
    • if > 10 minutes after pagehide, there need to be other tab/frame opening the same site.

Please correct if anything is wrong.

@caraitto
Copy link
Contributor Author

  1. Current design does respect background sync permission: Post-unload beacons are not sent if background sync is disabled for a site.

Oh -- this changes the privacy calculus significantly, I think, since the user explicitly allows the page to transmit when not active, barring that the transmission duration and frequency should be limited to avoid tracking [0].

I think we can remove the time limit requirements if the background sync permission is granted -- let me follow-up with some other reviewers offline.

...but, I'm not sure we want to encourage sites to ask for the background sync permission, just so they can send beacons, unless the user understands there is some clear user-focused benefit for enabling the permission (for instance, keeping content synced for offline use / startup speed boost from pre-loading). It seems to me there certainly are many sites that don't really need the background sync permission for their functionality, but they might still want to send metrics via beacons, and we want users to understand their personal risk / benefit tradeoff when granting permissions.

[0] https://wicg.github.io/background-sync/spec/#location-tracking

  1. If we lower the limit down to 10 minutes, some behavior of the API, i.e. sending on page/frame discard, will not be able to work on the browser that has longer bfcache limit (e.g. Mozilla is 45 minutes).

Could the page go into bfcache, send the beacons 10 minutes later, and then somehow get restored after that? I think the page would need to be informed that beacons were sent while it was bfcached, in case it wants to try sending again.

if there isn't another site open with the page content, that the beacon will need to be sent within 10 minutes of entering the bfcache -- is that OK? If not, we'd need further discussion, since the privacy-wise, the API would be more like background sync (which requires a permission)

  1. (Trying to summarize) After PR Lower the bfcache limit to 10 min. #41, for a beacon to live beyond the point of pagehide event:

    • Background Sync permission needs to be granted. Otherwise nothing will be sent and all beacons get dropped.
    • network must be the same (currently not able to ensure this, so the Chrome implementation just sends out on pagehide).
    • it has to be < 10 minutes after pagehide
    • if > 10 minutes after pagehide, there need to be other tab/frame opening the same site.

This SGTM (for the case where sync permission isn't granted -- I'm still following up offline on if we want to relax this when sync is granted). I assume "same site" means same eTLD+1, or in the same first party set.

@mingyc
Copy link
Collaborator

mingyc commented Oct 19, 2022

...since the user explicitly allows the page to transmit when not active
...but, I'm not sure we want to encourage sites to ask for the background sync permission, just so they can send beacons

Correct me if I am wrong, but at least in Chrome it looks like Background Sync is enabled by default for a normal user: the setting in chrome://settings/content/backgroundSync preselects the first item.

Screen Shot 2022-10-20 at 1 34 35 PM

@caraitto
Copy link
Contributor Author

My apologies, you're correct (I'm a little surprised by this) -- I discussed further offline, and everything you mentioned in #3 (comment) sounds correct (with exception of the question I asked about Mozilla's 45 minute time limit -- also, I'm checking if we really need to see if we're on the same network or not). So, background sync is required, and we still have the 10 min after bfcache limit, unless there's another frame of the same site (eTLD+1 / first party set).

@Sora2455
Copy link

Background Sync permission needs to be granted. Otherwise nothing will be sent and all beacons get dropped.

Quick clarification: if a site doesn't have the background sync permission, they register a pending beacon and the user closes the page, is the beacon:

  1. Sent immediately
  2. Never sent at all (making the API useless)

If it's the second, how does this work in browsers that haven't implemented background sync? And could this be called out early in the explainer so that web devs will know that they can't just replace their sendBeacon + unload combinations with pending beacons, as the explainer would otherwise imply?

@mingyc
Copy link
Collaborator

mingyc commented Oct 20, 2022

if a site doesn't have the background sync permission, they register a pending beacon and the user closes the page, is the beacon:

  1. Sent immediately
  2. Never sent at all (making the API useless)

The current Chrome implementation for Origin Trial is option 2: the browser never sends any beacons if a document is about to get destroyed for the document from a origin with BackgroundSync disabled. (If sendNow() is called manually or backgroundTimeout/timeout is set, beacon can still be sent)

I agree that this is not ideal.

Looking into the wording of the explainer

Post-unload beacons are not sent if background sync is disabled for a site.

and wording in BackgroundSync

Recently closed sites can finish sending and receiving data

I am not sure if we can interpret the above as "allowing to send beacons before unload is finished" to allow option 1. If so, maybe the API could still try to send those beacons out?


how does this work in browsers that haven't implemented background sync?

For the browsers that have not implemented BackgroundSync, one way to make this API work is to apply the current restrictions, i.e. shorter time limit, same network envrionment etc.

Need input from @caraitto, as I also hope that complying to BackgroundSync could give us more flexibility to send beacons anytime after pagehide/page closed, and help resolve network change issue (#30)


could this be called out early in the explainer so that web devs will know that they can't just replace their sendBeacon + unload combinations with pending beacons, as the explainer would otherwise imply?

I will update the explainer to call this out as suggested.


Adding some other network-leakage-related discussions:

@mingyc mingyc changed the title [Declarative Beacon API] Time limit on retaining beacons for bfcache'd pages [Privacy] Time limit on retaining beacons for bfcache'd pages Oct 20, 2022
@caraitto
Copy link
Contributor Author

@mingyc We've discussed some more -- there are 2 separate issues:

A

Another live instance of the same site is present in another tab, where same site means same eTLD+1 or same first party set. Here, we probably don't need the background sync permission, since the site is still active elsewhere. However, with frames, we might have to not transmit after navigate away / close if the network changed, since with the removal of third party cookies and storage partitioning, maps.company.com in a sub-frame has a separate identity from maps.company.com in a top-level frame. This requirement to not send the beacon after page close if the network changes only needs to apply if the live instance and bfcached instance belong to separate identities. For instance, these maps.company.com instances are each in separate identities:

top-level: foo.com, sub-frame: maps.company.com
top-level: bar.com, sub-frame: maps.company.com
top-level: maps.company.com

But, 2 instances of maps.company.com that are (top-level: foo.com, sub-frame: maps.company.com) would be in the same identity -- likewise, 2 top level maps.company.com instances would be same identity, and therefore could send even if the network changes.

(I believe intermediate parent frames aren't part of the identity key, just the top-level and current frame).

B

There is no other live instance of the same site. Transmitting beacons after navigating away from / closing the page will require the background sync permission. I'm waiting to hear from the permissions team what limits we'd like to set for this scenario.

jamienicol pushed a commit to jamienicol/gecko that referenced this issue Oct 6, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Revert "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.

Reason for revert:
Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html

https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview

Original change's description:
> [fetch-later] Force sending when BackgroundSync permission is off
>
> The [privacy decision][1] suggests: after user navigates away from
> a page, any pending requests left in the page should not be sent
> if [BackgroundSync permission][2] is off (default is on in Chrome).
>
> This CL forces sending out deferred requests on entering
> BackForwardCache if the page's BackgroundSync permission is off.
>
> [1]: WICG/pending-beacon#3 (comment)
> [2]: https://wicg.github.io/background-sync/spec/
>
> Bug: 1465781
> Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204080}

Bug: 1465781
Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Auto-Submit: Jian Li <jianli@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204260}

--

wpt-commits: 34e3a8a6cd3df89182ceea8c7b6e34a2b41c57d2
wpt-pr: 42294
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 13, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Revert "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.

Reason for revert:
Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html

https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview

Original change's description:
> [fetch-later] Force sending when BackgroundSync permission is off
>
> The [privacy decision][1] suggests: after user navigates away from
> a page, any pending requests left in the page should not be sent
> if [BackgroundSync permission][2] is off (default is on in Chrome).
>
> This CL forces sending out deferred requests on entering
> BackForwardCache if the page's BackgroundSync permission is off.
>
> [1]: WICG/pending-beacon#3 (comment)
> [2]: https://wicg.github.io/background-sync/spec/
>
> Bug: 1465781
> Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> Reviewed-by: Nidhi Jaju <nidhijajuchromium.org>
> Auto-Submit: Ming-Ying Chung <mychchromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
> Reviewed-by: Adam Rice <riceachromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
> Cr-Commit-Position: refs/heads/main{#1204080}

Bug: 1465781
Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
Reviewed-by: Cammie Smith Barnes <cammiechromium.org>
Owners-Override: Cammie Smith Barnes <cammiechromium.org>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Commit-Queue: Cammie Smith Barnes <cammiechromium.org>
Auto-Submit: Jian Li <jianlichromium.org>
Commit-Queue: Jian Li <jianlichromium.org>
Cr-Commit-Position: refs/heads/main{#1204260}

--

wpt-commits: 34e3a8a6cd3df89182ceea8c7b6e34a2b41c57d2
wpt-pr: 42294

UltraBlame original commit: f1829ff5122c4bb417fc134bbe6212f3d6513898
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 13, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Revert "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.

Reason for revert:
Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html

https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview

Original change's description:
> [fetch-later] Force sending when BackgroundSync permission is off
>
> The [privacy decision][1] suggests: after user navigates away from
> a page, any pending requests left in the page should not be sent
> if [BackgroundSync permission][2] is off (default is on in Chrome).
>
> This CL forces sending out deferred requests on entering
> BackForwardCache if the page's BackgroundSync permission is off.
>
> [1]: WICG/pending-beacon#3 (comment)
> [2]: https://wicg.github.io/background-sync/spec/
>
> Bug: 1465781
> Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> Reviewed-by: Nidhi Jaju <nidhijajuchromium.org>
> Auto-Submit: Ming-Ying Chung <mychchromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
> Reviewed-by: Adam Rice <riceachromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
> Cr-Commit-Position: refs/heads/main{#1204080}

Bug: 1465781
Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
Reviewed-by: Cammie Smith Barnes <cammiechromium.org>
Owners-Override: Cammie Smith Barnes <cammiechromium.org>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Commit-Queue: Cammie Smith Barnes <cammiechromium.org>
Auto-Submit: Jian Li <jianlichromium.org>
Commit-Queue: Jian Li <jianlichromium.org>
Cr-Commit-Position: refs/heads/main{#1204260}

--

wpt-commits: 34e3a8a6cd3df89182ceea8c7b6e34a2b41c57d2
wpt-pr: 42294

UltraBlame original commit: 345bb12ad7c2da4d08a3e5e81aa23c46cd2c5bfa
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 13, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Revert "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.

Reason for revert:
Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html

https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview

Original change's description:
> [fetch-later] Force sending when BackgroundSync permission is off
>
> The [privacy decision][1] suggests: after user navigates away from
> a page, any pending requests left in the page should not be sent
> if [BackgroundSync permission][2] is off (default is on in Chrome).
>
> This CL forces sending out deferred requests on entering
> BackForwardCache if the page's BackgroundSync permission is off.
>
> [1]: WICG/pending-beacon#3 (comment)
> [2]: https://wicg.github.io/background-sync/spec/
>
> Bug: 1465781
> Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> Reviewed-by: Nidhi Jaju <nidhijajuchromium.org>
> Auto-Submit: Ming-Ying Chung <mychchromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
> Reviewed-by: Adam Rice <riceachromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
> Cr-Commit-Position: refs/heads/main{#1204080}

Bug: 1465781
Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
Reviewed-by: Cammie Smith Barnes <cammiechromium.org>
Owners-Override: Cammie Smith Barnes <cammiechromium.org>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Commit-Queue: Cammie Smith Barnes <cammiechromium.org>
Auto-Submit: Jian Li <jianlichromium.org>
Commit-Queue: Jian Li <jianlichromium.org>
Cr-Commit-Position: refs/heads/main{#1204260}

--

wpt-commits: 34e3a8a6cd3df89182ceea8c7b6e34a2b41c57d2
wpt-pr: 42294

UltraBlame original commit: f1829ff5122c4bb417fc134bbe6212f3d6513898
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 13, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Revert "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.

Reason for revert:
Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html

https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview

Original change's description:
> [fetch-later] Force sending when BackgroundSync permission is off
>
> The [privacy decision][1] suggests: after user navigates away from
> a page, any pending requests left in the page should not be sent
> if [BackgroundSync permission][2] is off (default is on in Chrome).
>
> This CL forces sending out deferred requests on entering
> BackForwardCache if the page's BackgroundSync permission is off.
>
> [1]: WICG/pending-beacon#3 (comment)
> [2]: https://wicg.github.io/background-sync/spec/
>
> Bug: 1465781
> Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> Reviewed-by: Nidhi Jaju <nidhijajuchromium.org>
> Auto-Submit: Ming-Ying Chung <mychchromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
> Reviewed-by: Adam Rice <riceachromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
> Cr-Commit-Position: refs/heads/main{#1204080}

Bug: 1465781
Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
Reviewed-by: Cammie Smith Barnes <cammiechromium.org>
Owners-Override: Cammie Smith Barnes <cammiechromium.org>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Commit-Queue: Cammie Smith Barnes <cammiechromium.org>
Auto-Submit: Jian Li <jianlichromium.org>
Commit-Queue: Jian Li <jianlichromium.org>
Cr-Commit-Position: refs/heads/main{#1204260}

--

wpt-commits: 34e3a8a6cd3df89182ceea8c7b6e34a2b41c57d2
wpt-pr: 42294

UltraBlame original commit: 345bb12ad7c2da4d08a3e5e81aa23c46cd2c5bfa
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 13, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Revert "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.

Reason for revert:
Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html

https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview

Original change's description:
> [fetch-later] Force sending when BackgroundSync permission is off
>
> The [privacy decision][1] suggests: after user navigates away from
> a page, any pending requests left in the page should not be sent
> if [BackgroundSync permission][2] is off (default is on in Chrome).
>
> This CL forces sending out deferred requests on entering
> BackForwardCache if the page's BackgroundSync permission is off.
>
> [1]: WICG/pending-beacon#3 (comment)
> [2]: https://wicg.github.io/background-sync/spec/
>
> Bug: 1465781
> Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> Reviewed-by: Nidhi Jaju <nidhijajuchromium.org>
> Auto-Submit: Ming-Ying Chung <mychchromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
> Reviewed-by: Adam Rice <riceachromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
> Cr-Commit-Position: refs/heads/main{#1204080}

Bug: 1465781
Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
Reviewed-by: Cammie Smith Barnes <cammiechromium.org>
Owners-Override: Cammie Smith Barnes <cammiechromium.org>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Commit-Queue: Cammie Smith Barnes <cammiechromium.org>
Auto-Submit: Jian Li <jianlichromium.org>
Commit-Queue: Jian Li <jianlichromium.org>
Cr-Commit-Position: refs/heads/main{#1204260}

--

wpt-commits: 34e3a8a6cd3df89182ceea8c7b6e34a2b41c57d2
wpt-pr: 42294

UltraBlame original commit: f1829ff5122c4bb417fc134bbe6212f3d6513898
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 13, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Revert "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.

Reason for revert:
Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html

https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview

Original change's description:
> [fetch-later] Force sending when BackgroundSync permission is off
>
> The [privacy decision][1] suggests: after user navigates away from
> a page, any pending requests left in the page should not be sent
> if [BackgroundSync permission][2] is off (default is on in Chrome).
>
> This CL forces sending out deferred requests on entering
> BackForwardCache if the page's BackgroundSync permission is off.
>
> [1]: WICG/pending-beacon#3 (comment)
> [2]: https://wicg.github.io/background-sync/spec/
>
> Bug: 1465781
> Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> Reviewed-by: Nidhi Jaju <nidhijajuchromium.org>
> Auto-Submit: Ming-Ying Chung <mychchromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
> Reviewed-by: Adam Rice <riceachromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
> Cr-Commit-Position: refs/heads/main{#1204080}

Bug: 1465781
Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
Reviewed-by: Cammie Smith Barnes <cammiechromium.org>
Owners-Override: Cammie Smith Barnes <cammiechromium.org>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Commit-Queue: Cammie Smith Barnes <cammiechromium.org>
Auto-Submit: Jian Li <jianlichromium.org>
Commit-Queue: Jian Li <jianlichromium.org>
Cr-Commit-Position: refs/heads/main{#1204260}

--

wpt-commits: 34e3a8a6cd3df89182ceea8c7b6e34a2b41c57d2
wpt-pr: 42294

UltraBlame original commit: 345bb12ad7c2da4d08a3e5e81aa23c46cd2c5bfa
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 26, 2023
… off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 27, 2023
… off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 27, 2023
… off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 27, 2023
… off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 31, 2023
… off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 31, 2023
… off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
aarongable pushed a commit to chromium/chromium that referenced this issue Oct 31, 2023
… off"

This reverts commit 2e63732.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc36.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1217431}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 31, 2023
… off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1217431}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 31, 2023
… off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1217431}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 14, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Reland "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1217431}

--

wpt-commits: b40888afa9ab1d3e64c7085f4cf8972f56bfce1d
wpt-pr: 42306
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this issue Nov 15, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Reland "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1217431}

--

wpt-commits: b40888afa9ab1d3e64c7085f4cf8972f56bfce1d
wpt-pr: 42306
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 16, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Reland "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijajuchromium.org>
> > Auto-Submit: Ming-Ying Chung <mychchromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
> > Reviewed-by: Adam Rice <riceachromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
> > Cr-Commit-Position: refs/heads/main{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammiechromium.org>
> Owners-Override: Cammie Smith Barnes <cammiechromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammiechromium.org>
> Auto-Submit: Jian Li <jianlichromium.org>
> Commit-Queue: Jian Li <jianlichromium.org>
> Cr-Commit-Position: refs/heads/main{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
Reviewed-by: Adam Rice <riceachromium.org>
Commit-Queue: Ming-Ying Chung <mychchromium.org>
Cr-Commit-Position: refs/heads/main{#1217431}

--

wpt-commits: b40888afa9ab1d3e64c7085f4cf8972f56bfce1d
wpt-pr: 42306

UltraBlame original commit: 81f32719c9dc5d0fb20415a240487e4deb17f6f0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 16, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Reland "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijajuchromium.org>
> > Auto-Submit: Ming-Ying Chung <mychchromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
> > Reviewed-by: Adam Rice <riceachromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
> > Cr-Commit-Position: refs/heads/main{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammiechromium.org>
> Owners-Override: Cammie Smith Barnes <cammiechromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammiechromium.org>
> Auto-Submit: Jian Li <jianlichromium.org>
> Commit-Queue: Jian Li <jianlichromium.org>
> Cr-Commit-Position: refs/heads/main{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
Reviewed-by: Adam Rice <riceachromium.org>
Commit-Queue: Ming-Ying Chung <mychchromium.org>
Cr-Commit-Position: refs/heads/main{#1217431}

--

wpt-commits: b40888afa9ab1d3e64c7085f4cf8972f56bfce1d
wpt-pr: 42306

UltraBlame original commit: 81f32719c9dc5d0fb20415a240487e4deb17f6f0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 16, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Reland "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijajuchromium.org>
> > Auto-Submit: Ming-Ying Chung <mychchromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
> > Reviewed-by: Adam Rice <riceachromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
> > Cr-Commit-Position: refs/heads/main{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammiechromium.org>
> Owners-Override: Cammie Smith Barnes <cammiechromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammiechromium.org>
> Auto-Submit: Jian Li <jianlichromium.org>
> Commit-Queue: Jian Li <jianlichromium.org>
> Cr-Commit-Position: refs/heads/main{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
Reviewed-by: Adam Rice <riceachromium.org>
Commit-Queue: Ming-Ying Chung <mychchromium.org>
Cr-Commit-Position: refs/heads/main{#1217431}

--

wpt-commits: b40888afa9ab1d3e64c7085f4cf8972f56bfce1d
wpt-pr: 42306

UltraBlame original commit: 81f32719c9dc5d0fb20415a240487e4deb17f6f0
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 20, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Reland "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1217431}

--

wpt-commits: b40888afa9ab1d3e64c7085f4cf8972f56bfce1d
wpt-pr: 42306
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Nov 20, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Reland "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> > Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Adam Rice <ricea@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
> Auto-Submit: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1217431}

--

wpt-commits: b40888afa9ab1d3e64c7085f4cf8972f56bfce1d
wpt-pr: 42306
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 21, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Reland "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijajuchromium.org>
> > Auto-Submit: Ming-Ying Chung <mychchromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
> > Reviewed-by: Adam Rice <riceachromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
> > Cr-Commit-Position: refs/heads/main{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammiechromium.org>
> Owners-Override: Cammie Smith Barnes <cammiechromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammiechromium.org>
> Auto-Submit: Jian Li <jianlichromium.org>
> Commit-Queue: Jian Li <jianlichromium.org>
> Cr-Commit-Position: refs/heads/main{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
Reviewed-by: Adam Rice <riceachromium.org>
Commit-Queue: Ming-Ying Chung <mychchromium.org>
Cr-Commit-Position: refs/heads/main{#1217431}

--

wpt-commits: b40888afa9ab1d3e64c7085f4cf8972f56bfce1d
wpt-pr: 42306

UltraBlame original commit: e6965cc7032bf747c769f6c50ae724b8ee7e368a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 21, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Reland "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijajuchromium.org>
> > Auto-Submit: Ming-Ying Chung <mychchromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
> > Reviewed-by: Adam Rice <riceachromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
> > Cr-Commit-Position: refs/heads/main{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammiechromium.org>
> Owners-Override: Cammie Smith Barnes <cammiechromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammiechromium.org>
> Auto-Submit: Jian Li <jianlichromium.org>
> Commit-Queue: Jian Li <jianlichromium.org>
> Cr-Commit-Position: refs/heads/main{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
Reviewed-by: Adam Rice <riceachromium.org>
Commit-Queue: Ming-Ying Chung <mychchromium.org>
Cr-Commit-Position: refs/heads/main{#1217431}

--

wpt-commits: b40888afa9ab1d3e64c7085f4cf8972f56bfce1d
wpt-pr: 42306

UltraBlame original commit: e6965cc7032bf747c769f6c50ae724b8ee7e368a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 21, 2023
… BackgroundSync permission is off", a=testonly

Automatic update from web-platform-tests
Reland "[fetch-later] Force sending when BackgroundSync permission is off"

This reverts commit 2e63732c1a8b8120630c8678f1443282be5bae59.

Reason for revert: Fixed broken WPT. Rebased on the latest change.

Original change's description:
> Revert "[fetch-later] Force sending when BackgroundSync permission is off"
>
> This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.
>
> Reason for revert:
> Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview
>
> Original change's description:
> > [fetch-later] Force sending when BackgroundSync permission is off
> >
> > The [privacy decision][1] suggests: after user navigates away from
> > a page, any pending requests left in the page should not be sent
> > if [BackgroundSync permission][2] is off (default is on in Chrome).
> >
> > This CL forces sending out deferred requests on entering
> > BackForwardCache if the page's BackgroundSync permission is off.
> >
> > [1]: WICG/pending-beacon#3 (comment)
> > [2]: https://wicg.github.io/background-sync/spec/
> >
> > Bug: 1465781
> > Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> > Reviewed-by: Nidhi Jaju <nidhijajuchromium.org>
> > Auto-Submit: Ming-Ying Chung <mychchromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
> > Reviewed-by: Adam Rice <riceachromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
> > Cr-Commit-Position: refs/heads/main{#1204080}
>
> Bug: 1465781
> Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
> Reviewed-by: Cammie Smith Barnes <cammiechromium.org>
> Owners-Override: Cammie Smith Barnes <cammiechromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
> Commit-Queue: Cammie Smith Barnes <cammiechromium.org>
> Auto-Submit: Jian Li <jianlichromium.org>
> Commit-Queue: Jian Li <jianlichromium.org>
> Cr-Commit-Position: refs/heads/main{#1204260}

Bug: 1465781
Change-Id: I7abf6340a23066c0794e4d6010b5ce5ce64c8943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903454
Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org>
Reviewed-by: Adam Rice <riceachromium.org>
Commit-Queue: Ming-Ying Chung <mychchromium.org>
Cr-Commit-Position: refs/heads/main{#1217431}

--

wpt-commits: b40888afa9ab1d3e64c7085f4cf8972f56bfce1d
wpt-pr: 42306

UltraBlame original commit: e6965cc7032bf747c769f6c50ae724b8ee7e368a
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this issue Dec 11, 2023
The [privacy decision][1] suggests: after user navigates away from
a page, any pending requests left in the page should not be sent
if [BackgroundSync permission][2] is off (default is on in Chrome).

This CL forces sending out deferred requests on entering
BackForwardCache if the page's BackgroundSync permission is off.

[1]: WICG/pending-beacon#3 (comment)
[2]: https://wicg.github.io/background-sync/spec/

Bug: 1465781
Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Auto-Submit: Ming-Ying Chung <mych@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204080}
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this issue Dec 11, 2023
… off"

This reverts commit d32dc3635147aa9cb4638864865aa6f86f42f2f2.

Reason for revert:
Caused consistent failures for virtual/fetch-later/wpt_internal/fetch/fetch-later/send-on-deactivate-with-background-sync.tentative.https.window.html

https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/42380/overview

Original change's description:
> [fetch-later] Force sending when BackgroundSync permission is off
>
> The [privacy decision][1] suggests: after user navigates away from
> a page, any pending requests left in the page should not be sent
> if [BackgroundSync permission][2] is off (default is on in Chrome).
>
> This CL forces sending out deferred requests on entering
> BackForwardCache if the page's BackgroundSync permission is off.
>
> [1]: WICG/pending-beacon#3 (comment)
> [2]: https://wicg.github.io/background-sync/spec/
>
> Bug: 1465781
> Change-Id: I120fbbc13294c40fcf13162d5d786f97e2131367
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845750
> Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
> Auto-Submit: Ming-Ying Chung <mych@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204080}

Bug: 1465781
Change-Id: I09e342e97d52745610d751eb21ee694ccf24976c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908141
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Owners-Override: Cammie Smith Barnes <cammie@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Auto-Submit: Jian Li <jianli@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204260}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants