Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore removed self-assigned articles to the pool of available articles #5549

Open
Ibom99 opened this issue Dec 10, 2023 · 7 comments · May be fixed by #5621
Open

Restore removed self-assigned articles to the pool of available articles #5549

Ibom99 opened this issue Dec 10, 2023 · 7 comments · May be fixed by #5621

Comments

@Ibom99
Copy link

Ibom99 commented Dec 10, 2023

Current Behavior:

At the moment, the programs and event dashboard doesn't move self-assigned articles back to the pool of available articles when remove is selected, it deletes the article completely from the program.

Desired Behavior:

The self-assigned articles when removed should return to the list of available articles it should not be deleted from the program entirely.

Additional context:

  1. Self-Assigned Article

Screenshot (70)

  1. After selecting remove

Screenshot (71)

  1. Article not in the list of the available articles
    Screenshot (72)
@chinmay7016
Copy link

where can i find this file.

@ragesoss
Copy link
Member

This feature would touch a lot of files, mostly involving the Assignment model, along with related controllers and front-end components.

@fillingtothemomo
Copy link
Contributor

@ragesoss can I take this issue up?

@ragesoss
Copy link
Member

@fillingtothemomo yes, but I think this is a fairly complicated issue that, and it may take a number of iterations to figure out exactly what the implementation should look like.

@fillingtothemomo
Copy link
Contributor

@ragesoss Can you suggest some newcomer friendly issues for me to work on?

@ragesoss
Copy link
Member

@fillingtothemomo I think you should give #5489 a try. It looks like the other person isn't active on it anymore.

@ragesoss
Copy link
Member

A few clarifications of this issue:

  1. This should account for the possibility that the removed article is already present as an Available Article (and should simply remove the article, in that case).
  2. This new behavior should only apply to courses that are using Available Articles in the first place, but we don't actually have a good way to detect that option right now. Basically, we want this new behavior only for a course where the instructor chose the 'Instructor prepares a list' option in the assignment wizard. I think a good way to address this would be to add choose_articles_from_list as a tag in the researchwrite/wizard.yml file so that the courses where this should apply will have the choose_articles_from_list Tag. Then the behavior can be controlled on the backend in the controller by determining whether the course has that tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants