Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiffViewer relies on a Revisions table query #5806

Open
ragesoss opened this issue May 16, 2024 · 2 comments
Open

DiffViewer relies on a Revisions table query #5806

ragesoss opened this issue May 16, 2024 · 2 comments
Labels

Comments

@ragesoss
Copy link
Member

One of the unanticipated effects of deleting the Revisions table is that the DiffViewer feature is broken. It relies on a call to ArticlesController#details, which looks for a first revision and last revision of an edited article, and if those revisions are not found, there will be a JS error.

In this case, we should probably rework the frontend so that it does not rely on the Dashboard server to get the data it needs to render the diff from the earliest student revision to the latest one, perhaps by fetching the revision history of the article (within the date range of the course) and using that to find the earliest and latest revision.

@ragesoss ragesoss added the bug label May 16, 2024
@ragesoss ragesoss assigned ragesoss and unassigned ragesoss May 16, 2024
@ragesoss
Copy link
Member Author

@gabina this is relevant for you.

@gabina
Copy link
Member

gabina commented May 17, 2024

Took note of this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants