Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change student photo from background-image to an actual image element #241

Open
ericyoondotcom opened this issue Mar 18, 2024 · 2 comments
Labels

Comments

@ericyoondotcom
Copy link
Contributor

Right now, student ID photos are displayed with the background-image property instead of an img tag. This is bad for accessibility, and also it means you can't right click to save the image.

@ErikBoesen
Copy link
Collaborator

I see the accessibility argument (although to my understanding, alt text is not considered necessary for compliance with accessibility policies if the image in question is right next to a text label of what it represents), but I recall the lack of right-click support being intentional. I think I was concerned that individuals may be bothered if it's especially easy to download their photos. But it really doesn't change anything practically speaking so I am ambivalent about this.

@ErikBoesen
Copy link
Collaborator

I think there was some other reason I wanted to use background image instead. But I don't remember what it was anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants