Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unauthorized errors #253

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Unauthorized errors #253

wants to merge 2 commits into from

Conversation

ericyoondotcom
Copy link
Contributor

Description

Checklist

  • I have thoroughly tested my code
  • I have considered security and privacy implications of my changes
  • I have added one other developer, @ErikBoesen, and the Yalies Team Lead as Reviewers

@ErikBoesen
Copy link
Collaborator

This is not the correct solution. If a user is unauthorized we should simply redirect them to login before reaching the authenticated page. This is what we used to do, but I think I broke that when I redid the auth system last fall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikBoesen ErikBoesen Awaiting requested review from ErikBoesen ErikBoesen is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@ErikBoesen ErikBoesen

@ericyoondotcom ericyoondotcom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Affects prod] /about page gives permissions error when signed out
2 participants
@ericyoondotcom @ErikBoesen