Date Range filters don't include last day for DateTIme columns #8192
Unanswered
paulohecht
asked this question in
Help
Replies: 1 comment
-
Can I create an Issue from this and work on a fix? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
There was an extensive 2-year-long discussion in 2014 about the expected behavior of the Date Range filters when filtering DateTime columns. The verdict, based on some benchmarks, was that it should include resources within the last day.
#3529
After this discussion, we had the first fix merged in 2016:
#4504
Later, a new fix that restricts the change to DateTime fields, keeping Dates as a simple <=
#4705
With the release of Active Admin 3, in this PR: #8010, this behavior ended up being reverted to the
<= beginning of the day
that ends up, counter-intuitively, omitting resources timestamped on that day.I could not find any mention of this being an expected change anywhere.
After going through the contribution guide, I found this to be the place to ask if this is consensually considered an Issue and if I can contribute with a PR that addresses this problem and restores the original inclusive filter behavior.
Beta Was this translation helpful? Give feedback.
All reactions