Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin Taproot support / bech32m addresses #106

Open
AndreasGassmann opened this issue Nov 15, 2021 · 4 comments
Open

Bitcoin Taproot support / bech32m addresses #106

AndreasGassmann opened this issue Nov 15, 2021 · 4 comments
Assignees

Comments

@AndreasGassmann
Copy link
Member

Taproot support is currently being added to bitcoinjs-lib. Once their integration is released, we can add a new protocol, Bitcoin (Taproot).

bitcoinjs/bitcoinjs-lib#1742

@AndreasGassmann AndreasGassmann self-assigned this Nov 15, 2021
@motorina0
Copy link

@AndreasGassmann I just wanted to let you know that I have updated the PR above, now it uses (an injectable) tiny-secp256k1 for the taproot ecc functions (previously it had custom logic).

Any review / comment / testcase / suggestion is appreciated. It would help us get this logic quicker in the official release.

@AndreasGassmann
Copy link
Member Author

Thanks for your work and updating the PR. I will hopefully have time to look into it in the next few days and will give you feedback. Is there documentation available how tiny-secp256k1 can be injected and any other notable changes?

@motorina0
Copy link

Is there documentation available how tiny-secp256k1 can be injected

  • there are samples in the unit tests here and here
    • basically p2tr takes an extra optional parameter that must respect the TinySecp256k1Interface interface
    • there will also be some documentation once we decide on the final version
    • the fixtures can serve as sample data

any other notable changes

  • nothing extra. The code is actually lighter, some ECC logic has been replaced and tiny-secp256k1 used instead

@bZ404
Copy link

bZ404 commented Jan 17, 2024

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants