Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Almin: shouldReceivePayload(payload) #274

Open
azu opened this issue Aug 8, 2017 · 1 comment
Open

Almin: shouldReceivePayload(payload) #274

azu opened this issue Aug 8, 2017 · 1 comment
Labels
Status: Proposal

Comments

@azu
Copy link
Member

azu commented Aug 8, 2017 •
edited

Currently, store implement can receive only

  • DidExecutePayload
  • UserDefinedPayload
  • CompletePayload

This is implicitly defined.

We want to move the definition to user land.
In other word, almin use Store#shouldReceivePayload(payload): boolean before call Store#receivePayload

This approch has some pros and cons

Pros

  • A store can recive WillExecutePayload and other
  • A store can select payload without calling receivePayload
    • e.g.) MyStore only receive UserDefinedPayload

Cons

  • Increase function call.
@azu
Copy link
Member Author

azu commented Jan 18, 2018

Related #312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azu