Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect halftime resets and deal with them #18

Open
andrewda opened this issue Aug 18, 2016 · 0 comments
Open

Detect halftime resets and deal with them #18

andrewda opened this issue Aug 18, 2016 · 0 comments
Labels

Comments

@andrewda
Copy link
Owner

andrewda commented Aug 18, 2016

Some tournaments (at least ESL and ESEA) reset the score at halftime which makes HLTV think the half is starting from 0-0. We should detect this and deal with it.

half 1 score + half 2 score = real score

A potential solution:

When the reset event is fired, check if the score is equal to 15. If it is, save it as the half 1 score and add that to the half 2 score whenever emitting the score.

A potential issue with this solution is if the warmups of the server end at 15 rounds, and so everything after that is considered the second half, even if it really is the first half.

To deal with this issue, we might need to also implement "real round" detection, but this could be very tricky. There are a few ways we could do this, noted in #19.

@andrewda andrewda added the bug label Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant