Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): prevent usage of reserved control flow @ symbol in custom interpolation context for better parser failure #55809

Closed
wants to merge 1 commit into from
Closed

fix(compiler): prevent usage of reserved control flow @ symbol in custom interpolation context for better parser failure #55809

wants to merge 1 commit into from

Conversation

bougwal
Copy link
Contributor

@bougwal bougwal commented May 15, 2024 •
edited

  • Fixes the issue where using a reserved control flow @ symbol in a custom interpolation context yields improper parser feedback.

@pullapprove pullapprove bot requested a review from devversion May 15, 2024 14:10
fix(compiler): prevent usage of reserved control flow symbol in custo…
63b2524 
…m interpolation context.

* Fixes the issue where using a reserved control flow @ symbol in a custom interpolation context yields improper parser feedback.
@bougwal bougwal force-pushed the fix/compiler-interpolation-assertion branch from 7599e90 to 63b2524 Compare May 15, 2024 14:27
@devversion devversion requested a review from crisbeto May 15, 2024 16:30
@crisbeto
Copy link
Member

Given that the interpolation config is now deprecated, I'm not sure if we'd want to do this. cc @alxhub

@devversion
Copy link
Member

I was under impression it would be a temporary improvement that makes the situation more clear.

@bougwal
Copy link
Contributor Author

bougwal commented May 15, 2024

Hi Paul @devversion and Kristiyan @crisbeto , I opened the PR after Alex's confirmation here: #55772 (comment)

crisbeto
crisbeto approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I hadn't seen this discussion.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate labels May 15, 2024
@ngbot ngbot bot added this to the Backlog milestone May 15, 2024
@atscott
Copy link
Contributor

atscott commented May 16, 2024

This PR was merged into the repository by commit 2bb12ac.

atscott pushed a commit that referenced this pull request May 16, 2024
@atscott
fix(compiler): prevent usage of reserved control flow symbol in custo…
eba92cf 
…m interpolation context. (#55809)

* Fixes the issue where using a reserved control flow @ symbol in a custom interpolation context yields improper parser feedback.

PR Close #55809
@atscott atscott closed this in 2bb12ac May 16, 2024
@merfu merfu mentioned this pull request May 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

compiler: Parser interpolation assertion failure after the introduction of new control flow @ symbol syntax
4 participants
@bougwal @crisbeto @devversion @atscott