Fix gather_facts for Windows and shell dirname #83275
Open
+143
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix parallel fact gather in gather_facts when targeting Windows by ensuring the modules are run in async mode. Also added the dirname method to shell plugins to allow callers to get a shell specific parent directory path.
1 task
ansibot
added
bug
bcoca
reviewed
May 20, 2024
| def dirname(self, path: str) -> str: | ||
| # Using os.path.dirname will return an empty string when path uses | ||
| # backslashes. Using ntpath can handle both cases for Windows. | ||
| return ntpath.dirname(path) |
There was a problem hiding this comment.
should we add basename/abspath/norm to the shells or just as we find a need for them?
There was a problem hiding this comment.
I probably would do it as is, I was very reluctant to add more to the shell plugin just for this. Plus doing so here will make it harder to backport the fix as well.
Personally the better fix in my mind is to just pass in the results file as a single path rather than have async_status rebuild it from a dir and filename but as async_status for PowerShell is no longer in this repo we can't really make that change.
bcoca
removed
the
needs_triage
ansibot
added
the
stale_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix parallel fact gather in gather_facts when targeting Windows by ensuring the modules are run in async mode.
Also added the dirname method to shell plugins to allow callers to get a shell specific parent directory path.
Fixes: #83219
ISSUE TYPE