Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist year to URL #41

Open
ErikBoesen opened this issue Oct 26, 2020 · 1 comment
Open

Persist year to URL #41

ErikBoesen opened this issue Oct 26, 2020 · 1 comment
Assignees
@JonathanOppenheimer
Labels
enhancement New feature or request

Comments

@ErikBoesen
Copy link
Member

I think it would make sense to, for instance, set the URL to erikboesen.com/seniormap/2019 when the user selects 2019 as the year they want to view. I'm pretty sure there are ways to do this without reloading the page.
@JonathanOppenheimer JonathanOppenheimer added the enhancement New feature or request label Mar 16, 2021
@JonathanOppenheimer JonathanOppenheimer self-assigned this Apr 11, 2021
@AndrewLester
Copy link
Member

AndrewLester commented Apr 13, 2021 •
edited

Unfortunately github pages seems to do something odd with the URL that will just give back a 404 error whenever you go to a url like /seniormap/<number>. This would mean the year specific URLs can't be shared.

Instead, we can change the query string in the URL and work with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonathanOppenheimer JonathanOppenheimer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErikBoesen @JonathanOppenheimer @AndrewLester