TKey should be reference type, or compared against default

[Bouke]

Various places in the SignInManager compare the userId against null. This is a problem for value types, for example Guid. I cannot use Guid? in my TUser as it needs to implement IEquatable<TKey>.

public override Guid ConvertIdFromString(string id) => Guid.Parse(id);

This returns Guid.Empty if id == null. However Guid.Empty != null and various places now assume a valid user. I see two possible fixes for this:

1. Require TKey to be a reference type: null checks can remain as-is.
2. Replace null checks with default checks: Guid.Empty == default.

Some places where using a value type is a problem:

AspNetIdentity/src/Microsoft.AspNet.Identity.Owin/SignInManager.cs

Line 125 in b782674

if (userId == null)

AspNetIdentity/src/Microsoft.AspNet.Identity.Owin/SignInManager.cs

Line 170 in b782674

if (userId == null)

AspNetIdentity/src/Microsoft.AspNet.Identity.Owin/SignInManager.cs

Line 156 in b782674

return await GetVerifiedUserIdAsync().WithCurrentCulture() != null;