Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet libman update installs deprecated package versions #724

Open
LiteracyFanatic opened this issue Feb 14, 2024 · 1 comment
Open

dotnet libman update installs deprecated package versions #724

LiteracyFanatic opened this issue Feb 14, 2024 · 1 comment

Comments

@LiteracyFanatic
Copy link

Describe the bug

If a deprecated version of a package exists with a higher version number than the currently installed version, the tool will install the deprecated version. This only seems to happen with the cdnjs provider.

To Reproduce

Steps to reproduce the behavior:

  1. Add the following entry under libraries in libman.json:
    {
      "provider": "cdnjs",
      "library": "datatables.net@1.13.10",
      "destination": "wwwroot/assets/libs/datatables.net"
    }
  1. Run dotnet libman update datatables.net and the command will update to version 2.1.1 which is deprecated.

Expected behavior

Deprecated package versions should be ignored when updating.

Additional context

2.1.175+29a28921bd.RR

@jimmylewis
Copy link
Contributor

With CDNJS, the data used by libman comes from their catalog curation. In this case, CDNJS that says 2.1.1 is the latest version, and there's no indication from their API that it's been deprecated.

You could try sending them feedback via https://github.com/cdnjs/cdnjs/issues to either set another version as latest, or to add a feature to include deprecation metadata so that libman could consume that and exclude deprecated versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants