Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full line coloring is gone #79

Open
lczech opened this issue May 12, 2021 · 7 comments
Open

Full line coloring is gone #79

lczech opened this issue May 12, 2021 · 7 comments

Comments

@lczech
Copy link

lczech commented May 12, 2021

Hi there, and thanks for this amazing plugin!

Since a few days, I noticed that the minimap does not show lines with git diffs fully colorized, but just as a very small vertical strip on the left:

image

This makes it really hard to see where diffs are in the minimap. Is there a way to get the old behavior back, where the whole line was marked in orange or green in the minimap?

Thanks!

@UziTech
Copy link
Collaborator

UziTech commented May 12, 2021

Can you share your versions for Atom, minimap, minimap-git-diff, and OS?

@lczech
Copy link
Author

lczech commented May 12, 2021

Ah sorry, yes sure:

Ubuntu 20.04.2 LTS
Atom 1.57.0
minimap 4.39.14
minimap-git-diff 4.3.6

@UziTech
Copy link
Collaborator

UziTech commented May 12, 2021

There seems to be a lot of issues with ubuntu 20.04 and minimap.
@aminya could this be a canvas issue?

@lczech
Copy link
Author

lczech commented May 12, 2021

Hm, it was working fine a few days ago. Not sure what changed since.

@UziTech
Copy link
Collaborator

UziTech commented May 14, 2021

most likely updating Atom is what broke it. atom-minimap/minimap#795

Atom v1.56 updated electron to v9 which broke some things on linux.

@lczech
Copy link
Author

lczech commented May 27, 2021

Okay, thank you for the info! I guess we'll just wait for atom/minimap to fix this :-) Or is there anything else that we can do here? If not, feel free to close this issue!

@UziTech
Copy link
Collaborator

UziTech commented May 28, 2021

There is almost certainly not anything this plugin can do. Minimap handles all of the rendering so it might require a change in minimap or Atom. I'm guessing it is happening because the current version of Atom has a bug in canvas rendering on Ubuntu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants