Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent output for different number of channels #20

Open
dy opened this issue Sep 7, 2016 · 0 comments
Open

Inconsistent output for different number of channels #20

dy opened this issue Sep 7, 2016 · 0 comments

Comments

@dy
Copy link
Member

dy commented Sep 7, 2016

If we pick {channels: 1} but the input stream is stereo, and vice-versa, we get improperly scaled playratio.

The expected behaviour would be down/up-mixing the channels, like putting mono to the left 1 → 2 case, averaging stereo in 2 → 1 case, etc. See table.

Also that may consider up/downsampling, and in broader sense any input pcm format.

That might be a concern of a separate module, like audio-pcm-format, though I guess it is natural to expect from speaker to properly output any pcm format, if explicitly defined.

So that’s a tough one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants