Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build with node 12.10.0 #71

Open
jpedrick opened this issue Sep 14, 2019 · 2 comments
Open

Does not build with node 12.10.0 #71

jpedrick opened this issue Sep 14, 2019 · 2 comments

Comments

@jpedrick
Copy link

jpedrick commented Sep 14, 2019

Running npm install web-audio-engine with node v12.10.0

npm install --save web-audio-engine
npm WARN deprecated scijs-window-functions@2.0.2: This package has been renamed 'window-function'. The API is otherwise the same. Please switch.

> speaker@0.3.1 install /home/jpedrick/Development/node_modules/speaker
> node-gyp rebuild

make: Entering directory '/home/jpedrick/Development/node_modules/speaker/build'
  CC(target) Release/obj.target/output/deps/mpg123/src/output/alsa.o
../deps/mpg123/src/output/alsa.c: In function ‘initialize_device’:
../deps/mpg123/src/output/alsa.c:78:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
  for (i = 0; i < NUM_FORMATS; ++i) {
                ^
../deps/mpg123/src/output/alsa.c: In function ‘get_formats_alsa’:
../deps/mpg123/src/output/alsa.c:201:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
  for (i = 0; i < NUM_FORMATS; ++i) {
                ^
  AR(target) Release/obj.target/deps/mpg123/liboutput.a
  COPY Release/liboutput.a
  CXX(target) Release/obj.target/binding/src/binding.o
In file included from ../src/node_pointer.h:6,
                 from ../src/binding.cc:5:
../../nan/nan.h: In function ‘void Nan::AsyncQueueWorker(Nan::AsyncWorker*)’:
../../nan/nan.h:2298:62: warning: cast between incompatible function types from ‘void (*)(uv_work_t*)’ {aka ‘void (*)(uv_work_s*)’} to ‘uv_after_work_cb’ {aka ‘void (*)(uv_work_s*, int)’} [-Wcast-function-type]
     , reinterpret_cast<uv_after_work_cb>(AsyncExecuteComplete)
                                                              ^
../src/binding.cc: In function ‘Nan::NAN_METHOD_RETURN_TYPE {anonymous}::Open(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/binding.cc:30:38: error: no matching function for call to ‘v8::Value::Int32Value()’
   ao->channels = info[1]->Int32Value(); /* channels */
@cowboybkit
Copy link

It seem support to v10.x.x. I tested with 10.16.3

@oclyke
Copy link

oclyke commented May 3, 2021

Also seems to have issues with node 14.x LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants