-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(codebuild): Add support new newly introduced event filter #30062
Closed
1 of 2 tasks
Labels
@aws-cdk/aws-codebuild
Related to AWS CodeBuild
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
Comments
aseppala
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
May 5, 2024
aseppala
changed the title
(code build): Add support new newly introduced event filter
(codebuild): Add support new newly introduced event filter
May 5, 2024
This was referenced May 6, 2024
khushail
added
p2
effort/small
Small work item – less than a day of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
May 6, 2024
1 task
Until this issue is resolved, a working workaround is to use CDK escape hatch: import { CfnProject, Project, Source, FilterGroup, EventAction } from 'aws-cdk-lib/aws-codebuild';
const project = new Project(this, 'Project', {
projectName: props.projectName,
source: Source.gitHub({
...
webhookFilters: [
FilterGroup.inEventOf(EventAction.PULL_REQUEST_CREATED),
],
}),
})
const cfnProject = project.node.defaultChild as CfnProject
const triggers = cfnProject.triggers as CfnProject.ProjectTriggersProperty
const filterGroups = triggers.filterGroups as CfnProject.WebhookFilterProperty[][]
// remove wrong (PULL_REQUEST_CREATED) filter
filterGroups[0].pop()
// add correct (WORKFLOW_JOB_QUEUED) filter
filterGroups[0].push({
type: 'EVENT',
pattern: 'WORKFLOW_JOB_QUEUED',
}) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-codebuild
Related to AWS CodeBuild
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
Describe the feature
A new feature has been recently introduced in AWS CodeBuild: https://aws.amazon.com/about-aws/whats-new/2024/04/aws-codebuild-managed-github-action-runners/. This feature enables to use AWS CodeBuild as GitHub Actions runner. However, using this feature requires to configure a new event filter which is currently not yet available in CDK.
Use Case
To be able to use 'aws-cdk-lib/aws-codebuild.Project' L2 Construct to define a runner for Github Action I need to be able to pass in
FilterGroup.inEventOf(EventAction.WORKFLOW_JOB_QUEUED)
but its not available so for now I'm force to use L1 Construct which requires setting up IAM roles etc which would be automatically created by the Project construct.Proposed Solution
Introduce new value to
aws-cdk-lib/aws-codebuild.EventAction
enum: "WORKFLOW_JOB_QUEUED"Other Information
No response
Acknowledgements
CDK version used
2.140.0
Environment details (OS name and version, etc.)
MacOS 14.3.1 (23D60)
The text was updated successfully, but these errors were encountered: