-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem in basic usage #33
Comments
I am also having this problem. I'm using really-need to test my express server with mocha like this:
I'm using Node 4.4.2 if that helps at all. The error message I get is identical to the one above. |
I think this is due to the source for require changing in Node 4.4.2 - could you try earlier Node versions please? |
Sorry this took so long. I reverted back to 4.0.0 and it seems to be working fine there. 4.4.4, 4.4.2, and 4.3.2 don't seem to work, though. |
Thanks for trying different versions - yes, the node module loading code has changed and really-need fails to properly replace it. I will take a look at this when I get a chance |
Same issue here. Works in 4.0.X, 4.1.X, 5.0.X, 5.1.X, seems to fail for 4.2.6+, and 5.2.X+, didn't test all patch releases and also didn't test 3.X.X-. I really need this to work soon :D — building a test runner that depends on it. What's involved with fixing this? Maybe I can lend a hand. |
Seems the problem is that different versions patched the module loading system, and the way I overloaded it using |
Same problem with node 4.4.0. Reverting Node to 4.0.0 seems to work. I'm quite sure that I was running okay with Node 4.4.0 previously, though. Was this error introduced in a specific really-need version? Tried rolling back really-need but ended up with the shebangRe error instead. |
@bahmutov It might be a bit of a tall order, but I was thinking all versions 4.0.0 and above. However, I did manage to get my use case (4.0.0+) resolved with require-hacker. I still think that |
Hello, I just wanted to check and see if there might be a fix for this in the works. I'd very much like to be able to use really-need in my testing. Thank you very much for your time. |
@bahmutov This package even maintained anymore??? This issue was opened in March 2016 and it's been almost 2 years without a fix. |
Sorry about the delay, I did not need it lately so the thing was not updated. Especially because it is using internals of node which are changing with each v8 release
…Sent from my iPhone
On Feb 25, 2018, at 17:47, Charlie Fish ***@***.***> wrote:
@bahmutov This package even maintained anymore??? This issue was opened in March 2016 and it's been almost 2 years without a fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@bahmutov If that is the case you should archive the repo on GitHub or post a note in the README that this project is no longer actively maintained. |
nope, if someone submits pull requests, the issue can be solved, new version can be released, etc. |
Hello, thanks a lot for this library.
I am evaluating it to see if I could use for a mutation testing library I am writing, I've setup a basic scenario to see how it works:
When I run it it gives me an error, it's quite long, I'll paste what I think it's relevant (here the whole thing https://gist.github.com/lazywithclass/93898774a3644be63c32)
I am running node 4.3.1and really-need 1.9.2.
Any hint / help would be greatly appreciated.
UPDATE: Using node 4.2.2 and
fake
seems to solve the issue... but still I am looking at your code to understand how can I use it with newer versions.The text was updated successfully, but these errors were encountered: