Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Representation of repo rules in performance artifacts #22439

Open
emaxx-google opened this issue May 17, 2024 · 0 comments
Open

Representation of repo rules in performance artifacts #22439

emaxx-google opened this issue May 17, 2024 · 0 comments
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request untriaged

Comments

@emaxx-google
Copy link

emaxx-google commented May 17, 2024

Description of the feature request:

This feature request is about improving the representation of repo rules in Bazel's performance artifacts: trace profiles, exec logs, graph logs.

IIUC, currently the following limitations exist:

  • repo rules aren't displayed in trace profiles as lying on the critical path even when they actually do;
  • repo rules don't have the out field populated in trace profiles (--experimental_profile_include_primary_output);
  • exec logs don't record invocations of the repo rules;
  • graph logs have no nodes nor edges representing repo rules.

Having at least some of these fixed would be useful for projects like ChromeOS which have big repo rules (in our case, at the order of magnitude of 10 minutes). Currently we work it around by implementing the drag analysis ourselves after heuristically backfilling the missing edges to repo rules, but it'd be nice if these hacks weren't necessary in order to get unbiased performance analysis.

Which category does this issue belong to?

Core

What underlying problem are you trying to solve with this feature?

Better understanding of performance and bottlenecks in builds.

Which operating system are you running Bazel on?

Linux

What is the output of bazel info release?

7.1.0

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@github-actions github-actions bot added the team-Core Skyframe, bazel query, BEP, options parsing, bazelrc label May 17, 2024
@haxorz haxorz added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed team-Core Skyframe, bazel query, BEP, options parsing, bazelrc labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request untriaged
Projects
None yet
Development

No branches or pull requests

5 participants