Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --workspaces to run on all npm workspaces #60

Open
voxpelli opened this issue Sep 29, 2021 · 6 comments
Open

Add support for --workspaces to run on all npm workspaces #60

voxpelli opened this issue Sep 29, 2021 · 6 comments

Comments

@voxpelli
Copy link
Collaborator

voxpelli commented Sep 29, 2021

I'm thinking it would be neat to be able to do:

run-p --workspaces check:*

Related issues:

Interesting modules:

@bcomnes
Copy link
Owner

bcomnes commented Sep 29, 2021

Makes sense now that npm supports workspaces.

@voxpelli
Copy link
Collaborator Author

When --max-parallel is set, should it try to spread out the executions across the workspaces or just assemble a long list of all tasks to be run and execute them from top to bottom?

The latter would be more a 1:1 between run-s --workspaces and run-p --workspaces but I kind of like the idea of balancing it across the different workspaces. Probably overengineering to do though, right?

@bcomnes
Copy link
Owner

bcomnes commented May 18, 2023

Probably do what ever is simplest to implement and maintain.

@voxpelli voxpelli self-assigned this May 18, 2023
@voxpelli
Copy link
Collaborator Author

I'm going to give it a stab now

@bcomnes
Copy link
Owner

bcomnes commented May 18, 2023

If you do take a stab at this, feel free to refactor ancient promise callbacks to async await etc. Whatever cleans it up.

@voxpelli
Copy link
Collaborator Author

Created a helper for reading all packages from a workspace, with similar filtering as npm itself has: https://github.com/voxpelli/read-workspaces

Started using it in list-installed and as such also in installed-check / installed-check-core now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants