Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose animation clone APIs built for MA in NDMF #111

Open
bdunderscore opened this issue Jan 6, 2024 · 1 comment
Open

Expose animation clone APIs built for MA in NDMF #111

bdunderscore opened this issue Jan 6, 2024 · 1 comment
Milestone
1.4.0

Comments

@bdunderscore
Copy link
Owner

No description provided.

@bdunderscore bdunderscore added this to the 1.4.0 milestone Jan 6, 2024
@kaikoga
Copy link
Contributor

kaikoga commented Jan 27, 2024

FYI: I had to implement VRM-related ScriptableObject clone API in bdunderscore/modular-avatar#602

enitimeago added a commit to enitimeago/make-it-mmd that referenced this issue Feb 4, 2024
@enitimeago
Move animator cloning into write defaults pass
9fd3e06 
If this was a larger project it may make sense to only do it once in the NDMF resolving phase, but otherwise this is a case of YAGNI. Cloning in the write defaults pass is fine. We can revisit this decision if more passes end up needing this. Ideally bdunderscore/ndmf#111 lands and we can migrate to that instead, since it's already duplicate work for this and Modular Avatar to both do a deep clone of avatar FX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@kaikoga @bdunderscore