Test your code

[edouard-lopez]

Please test your code using a bash framework such as bash_unit or any another you like.

This will improve the code quality and prevent regression.

The following would need to be unit-tested:

• getdeps (MR [WIP] Add unit-tests for getdeps. #112)
• init
• install
• json (already has tests)
• list
• package
• setup
• show
• suggest
• term
• update
• utils (MR [WIP] Add unit-tests for bpkg_utils #113)

[joseluis]

I agree with @edouard-lopez that adding unit tests is important long-term. I personally like Bats and assert.sh but any would do the job. Also it would be nice to connect the repo with travis-ci for automatic testing.

Also it would be good to review the code quality with shellcheck, and fix the few issues present. Also you could to connect the repo with code-climate for automating review.

[Potherca]

Just opened #112 to add tests to getdeps

[Potherca]

Started work for utils in #113

[Potherca]

Note to self: We should check which files caused the most issues lately and prioritize those for testing first!

[jwerle]

Note to self: We should check which files caused the most issues lately and prioritize those for testing first!

yes! I've broken (and fixed) so many things 😅

[Potherca]

Well, running this:

git log --oneline --stat | grep '|' | cut -d ' ' -f2 | sort | uniq -c | sort -r -h

The top 5 bash files are:

1. 65 lib/install/install.sh
2. 40 bpkg.sh
3. 21 lib/init/init.sh

Limited to the last 50 commit, that is:

1. 22 lib/install/install.sh
2. 12 lib/init/init.sh
3. 10 lib/show/show.sh

So I think lib/install/install.sh, bpkg.sh, lib/init/init.sh and lib/show/show.sh will have to come first...