Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra spaces after link and description #1

Open
jaydson opened this issue Oct 3, 2018 · 11 comments
Open

Extra spaces after link and description #1

jaydson opened this issue Oct 3, 2018 · 11 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jaydson
Copy link
Member

jaydson commented Oct 3, 2018

There some extra spaces after link and description on each item.
@jaydson jaydson added bug Something isn't working good first issue Good for newcomers labels Oct 3, 2018
@alvarocamillont
Copy link

Can I try that?

@jaydson
Copy link
Member Author

jaydson commented Oct 3, 2018

Sure @AlvaroCNeto ! Let me know if you need help in the process :)
Are you participating in the Hacktoberfest?

@alvarocamillont
Copy link

Yep!

@jaydson
Copy link
Member Author

jaydson commented Oct 4, 2018

Awesome!

@RenatoSiqueira
Copy link
Contributor

@AlvaroCNeto
this removes the last '_' present in name link.
do you wanna try to make PR?

image

@alvarocamillont
Copy link

Thanks!

But you found it, so its not right for me to take your PR...

I will find another issue 👍

Thanks!

@RenatoSiqueira
Copy link
Contributor

RenatoSiqueira commented Oct 6, 2018 •
edited

ok.
Done in PR #27

RenatoSiqueira added a commit to RenatoSiqueira/newslleter-tool that referenced this issue Oct 8, 2018
@RenatoSiqueira
Issue braziljs#5/ braziljs#1
487ef99
This was referenced Oct 8, 2018
Merged
Closed
@RenatoSiqueira
Copy link
Contributor

image

I dont see this problem.

@jaydson
Copy link
Member Author

jaydson commented Oct 12, 2018

Hey @RenatoSiqueira , the extra spaces are invisible, but when I copy and paste on Maichimp I can see that it is there.
Look at the screenshot below.

screenshot from 2018-10-12 12-00-57

@RenatoSiqueira
Copy link
Contributor

hm... i understand now.
if anybody wants to see this, go ahead.
maybe i look too...

jaydson pushed a commit that referenced this issue Oct 13, 2018
@JulioGold
Merge pull request #1 from braziljs/master
70bee25 
Update fork
@JulioGold JulioGold mentioned this issue Oct 16, 2018
Merged
@JulioGold
Copy link
Contributor

I did some pr #38.

I think it's ok now.

jaydson pushed a commit that referenced this issue Oct 16, 2018
Removed extra spaces #1
880dffc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jaydson @JulioGold @alvarocamillont @RenatoSiqueira