Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build.ps1: Use Minimal Distribution instead of Standard Distribution #56

Open
merceyz opened this issue Dec 2, 2017 · 3 comments
Open

Comments

@merceyz
Copy link
Member

merceyz commented Dec 2, 2017

CEF issue 2169 has been resolved, this means build.ps1 can use the Minimal Distribution instead of the Standard Distribution to speed up the download, and as a result, total build time.

https://bitbucket.org/chromiumembedded/cef/issues/2169/support-building-just-libcef_dll_wrapper

@perlun
Copy link
Member

perlun commented Dec 2, 2017

Good point @merceyz. Will you do it it? 😉

I think we should also do something about the builds in general, the AppVeyor stats doesn't seem to be reporting back to this repo as it should. Would be nice to always see it red/green on a PR as usual.

@merceyz
Copy link
Member Author

merceyz commented Dec 3, 2017

I think we should also do something about the builds in general, the AppVeyor stats doesn't seem to be reporting back to this repo as it should. Would be nice to always see it red/green on a PR as usual.

Probably due to

skip_non_tags: true

@perlun
Copy link
Member

perlun commented Dec 3, 2017

Probably due to

cef-binary/appveyor.yml

Line 9 in a9fadc9
skip_non_tags: true

Correct. I also saw it in the web UI, so I've changed it there (because it need it for another change I'm working on.)

But yeah, it should be fixed in the .yml as well. Feel free to fix it if you like.

@perlun perlun mentioned this issue Dec 7, 2017
@amaitland amaitland reopened this Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants