Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor: Build on all PRs #63

Open
perlun opened this issue Dec 8, 2017 · 1 comment
Open

AppVeyor: Build on all PRs #63

perlun opened this issue Dec 8, 2017 · 1 comment

Comments

@perlun
Copy link
Member

perlun commented Dec 8, 2017

We should look into changing this setting, so that we build on all PRs. This helps us verify changes in build.ps1 more easily.

The easiest way to fix this from what I can tell would be to tweak this part to set the NuGet package version like this, unless $env:APPVEYOR_REPO_TAG -eq "True"

(In other words, we will get junk version numbers like 62.0.0-CI34 until we tag the repo; for these builds, we will set the NuGet package version to match the tag just like we've done historically.)

Anyone wants to fix this - feel free, it's up for grabs.

@perlun perlun mentioned this issue Dec 8, 2017
perlun referenced this issue Dec 25, 2017
Remove need for hack checks to determine if the target is a x86 or x64 build

build.ps1 - Remove unused Nupkg variable
Variable was empty and has been removed from nuspec file

Switch to appveyor nuget feed
@amaitland
Copy link
Member

I've successfully pushed packages to the cef-binary project feed hosted by appveyor, see commit 76e9529

The publicly accessible feed URL is https://ci.appveyor.com/nuget/cef-binary-ci

I'm only pushing packages to the feed when a tag is detected, so this should bring this one step closer. The build script can probably be changed to build a specific version if a tag is detected, with the default being to grab the most recent version available from Spotify. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants