Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[servers/soundblaster] Starting the modplayer twice causes an invalid page fault #149

Open
perlun opened this issue Jul 7, 2019 · 2 comments
Labels

Comments

@perlun
Copy link
Contributor

perlun commented Jul 7, 2019

This is what you get:

image

Ugly crashes like this should clearly be avoided. What we should do instead is let the soundblaster server detect that the sound card is already busy and reject the call from the modplay process.

Out of scope

Support mixing audio from multiple processes at once. Doing this would be a substantially more advanced topic than just avoiding crashing.

@doverhill
Copy link

Mixing audio from multiple "senders" should just be adding up buffers byte-wise (clipping to 255 max)

@perlun
Copy link
Contributor Author

perlun commented Jul 9, 2019

Mixing audio from multiple "senders" should just be adding up buffers byte-wise (clipping to 255 max)

Are you sure? Sounds almost too simple to me, but... I'm not an expert in computer audio.

@perlun perlun added the bug label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants