please squash all in single commit

please squash all in single commit

Done

@patchwork01, please resolve Checker and Pitest failures.

please review if we can avoid this: https://github.com/checkstyle/checkstyle/actions/runs/8466706931/job/23196469563?pr=14690#step:6:933

New surviving error(s) found:

  <checkerFrameworkError unstable="false">
    <fileName>src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SummaryJavadocCheck.java</fileName>
    <specifier>argument</specifier>
    <message>incompatible argument for parameter end of StringBuilder.append.</message>
    <lineContent>result.append(text, 0, periodIndex);</lineContent>
    <details>
      found   : int
      required: @LTEqLengthOf(&quot;text&quot;) int
    </details>
  </checkerFrameworkError>

if not, just run groovy ./.ci/checker-framework.groovy checker-index on your local and add generated update/change to suppression file to your PR. It will be red flag for each reviewer, so better to share reasons why we cannot fix it, or it is not reasonable, or ... .

last testing request, please read https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#basic-difference-report-with-custom-projects-list and provide such two configs and lets test on bunch of real code. Result will be diff report, we need o make sure there is not unexpected regressions.

please review if we can avoid this: https://github.com/checkstyle/checkstyle/actions/runs/8466706931/job/23196469563?pr=14690#step:6:933

That's fixed now.

last testing request, please read https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#basic-difference-report-with-custom-projects-list and provide such two configs and lets test on bunch of real code. Result will be diff report, we need o make sure there is not unexpected regressions.

I'm not sure what you mean. What do you want me to do?

please read https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#executing-generation

Example configuration in PR description and triggering for different Check - #14743

GitHub, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/3043b4f_2024161246/reports/diff/index.html

Regression only ran against default SummaryJavadoc. We need run with change in property.

The only meaningful config we can run on is https://github.com/checkstyle/checkstyle/pull/14690/files#diff-86ad081949df60d8dd42db875094b5df6d70aed3f23759b7520605bfc23f86beR5
But we do not have Japanese open source projects in list, so no changes will be.
We can run, will it be enough?

If not, please share what configs you think we need to run on

by means of https://github.com/search?q=+language%3AJava++%E3%80%82&type=code
I found: https://github.com/Wechat-Group/WxJava

Github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/3043b4f_2024142716/reports/diff/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/3043b4f_2024142716/reports/diff/index.html

Report should have all projects.

please share what configs you think we need to run on

Use the same config, but also include the US period. Based on the logic presented here, it will assume it has a space after it so I should differences between this and the other config with the default.

Use the same config, but also include the US period. Based on the logic presented here, it will assume it has a space after it so I should differences between this and the other config with the default.

The US period is the default. That's the configuration that was used in this run 5 days ago. We can set the period character explicitly, but it won't be any different.

Github, generate report

GitHub, generate report

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/9171202334

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/9171243385

GitHub, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/84bd50f_2024114941/reports/diff/index.html

We can set the period character explicitly, but it won't be any different.

My fault, I missed this in the documentation.

Please provide the regression of the japanese period on all projects.

Semaphore is restarted, it was real problem after merge of unrelated PR. Should be green after restart

GitHub, generate report

Report generation failed on phase ,
step .
Link: https://github.com/checkstyle/checkstyle/actions/runs/9177354955

GitHub, generate report

Report generation failed on phase ,
step .
Link: https://github.com/checkstyle/checkstyle/actions/runs/9177422046

GitHub, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/84bd50f_2024164305/reports/diff/index.html

@rnveach , done, no changes.

@rnveach , please finish review

GitHub, generate report

configs are at https://github.com/checkstyle/test-configs/tree/main/SummaryJavadoc/japan-period

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/84bd50f_2024132644/reports/diff/index.html