Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PSB files #2

Open
rahul-dutt-sharma opened this issue Jul 2, 2019 · 6 comments
Open

Support PSB files #2

rahul-dutt-sharma opened this issue Jul 2, 2019 · 6 comments

Comments

@rahul-dutt-sharma
Copy link

It is going to be a more common use case with a lot of photoshop end use cases relying on

@chinedufn
Copy link
Owner

Hey @rahul-dutt-sharma !

Thanks for the feature request - just a couple of questions to help me better understand the scope.

  • What exactly led you to request PSB support. I agree that it'd be useful - just trying to understand what you ran into that made you open this issue

Ultimately PSB support seems to come down to reading a few extra bytes in some places - so this shouldn't be too hairy!

@rahul-dutt-sharma rahul-dutt-sharma changed the title feature request - add support for PSB files feature request - make it feature complete for product usage Jul 2, 2019
@rahul-dutt-sharma
Copy link
Author

I found this and sadly there is nothing in rust that comes close. https://psd-tools.readthedocs.io/en/latest/

I read through your code and am inclined on continuing with it as it is in Rust, which I have just picked up as my first system programming language

I would like to continue and not switch over to the python option

The missing features that belong to my use case sadly (or luckily) are to undestand the layout of the document, and for that I need to be able to read

  • smart objects
  • images embedded in some other form [not a photoshop pro here]
  • Text Styles

I believe I can live without the ability to read strokes data that PS saves

Thanks again

@rahul-dutt-sharma
Copy link
Author

Hey @rahul-dutt-sharma !

Thanks for the feature request - just a couple of questions to help me better understand the scope.

  • What exactly led you to request PSB support. I agree that it'd be useful - just trying to understand what you ran into that made you open this issue

Ultimately PSB support seems to come down to reading a few extra bytes in some places - so this shouldn't be too hairy!

I have the need to read really high dense files which I believe what PSB does
I don't have one on me, but I expect to get these when I get into testing my app

@rahul-dutt-sharma
Copy link
Author

P.S. Inspired by your wasm demo, I have taken up to learn rust and would probably be adding code to your project :)

@chinedufn
Copy link
Owner

chinedufn commented Jul 8, 2019

@rahul-dutt-sharma just a heads up I haven't gone silent! Planning to take a look at both of your issues this week!! Thanks so much! I'll get back to this shortly!

@chinedufn
Copy link
Owner

Thanks for getting back to me with so much detail - much appreciated!

P.S. Inspired by your wasm demo, I have taken up to learn rust and would probably be adding code to your project :)

This is very exciting - I'm looking forwards to your contributions.


It looks like there are a few things you want support for. How about we leave this issue for PSB files and open up separate ones for the other things you want (such as smart objects).

Also, any interest in implementing support for any of these things? I'd be more than happy to help by writing up a detailed plan / thoughts on approach for any functionality that you might want to add to they psd crate - if that's helpful for you.

Cheers!

@chinedufn chinedufn changed the title feature request - make it feature complete for product usage Support PSB files Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants