Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failure dependency #9

Open
chinedufn opened this issue Mar 13, 2020 · 1 comment
Open

Remove failure dependency #9

chinedufn opened this issue Mar 13, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@chinedufn
Copy link
Owner

It's our only dependency and there aren't enough errors to be worth pulling in syn - so we should move to some hand written error impls

@chinedufn
Copy link
Owner Author

Eh a downside to having zero error library dependencies would be that it discourages contributors from adding new errors since there is more friction.

So maybe for now we

  1. Remove failure
  2. Replace it with thiserror

And then if things one day stabilize we can consider removing thiserror and replace it with hand written errors.

Alternatively we might just stick with thiserror. Who knows.

For now we'll replace failure with thiserror and that satisfies this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant