Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document bankai build options #451

Open
tnguyen14 opened this issue Mar 21, 2018 · 1 comment
Open

Document bankai build options #451

tnguyen14 opened this issue Mar 21, 2018 · 1 comment

Comments

@tnguyen14
Copy link

I just stumbled into 2 options for the build command that were really critical for me, but I didn't see them documented anywhere. I had to search through the issues and pull requests to find them.

bankai build index.js docs # output dir into a different path than the default "dist"
bankai build index.js --base https://domain.com/sub-path # prepend a base href to scripts/ styles URL

I was going to create a PR to add these, but I am not sure how these options should be handled, as they're only specific to the build commands. The current docs show options that are applicable to the other commands as well.

Please let me know. More than happy to help with this.

@goto-bus-stop
Copy link
Member

goto-bus-stop commented Mar 23, 2018

Hey thanks! Maybe a bankai build section nested inside the Usage section in the readme would be good? And a bankai --help build command similar to how bankai --help config works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants