Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SW versioning #14

Open
sholtomaud opened this issue Aug 10, 2017 · 3 comments
Open

SW versioning #14

sholtomaud opened this issue Aug 10, 2017 · 3 comments

Comments

@sholtomaud
Copy link

I pulled down the latest version 6 of Choo using create-Choo-app. I love the work.

This might be a question for bankai. Running npm build leaves the sw.js in the top dir. Are you planning on integrating sw.js versioning and cp to build directory? (I think we discussed this on twitter) I've linked to a quick YouTube of supercharged js which uses gulp to do this

https://m.youtube.com/watch?v=ruKbxoFACp8

@YerkoPalma
Copy link
Member

I think this is resolved right now. Could anyone confirm?

@sholtomaud
Copy link
Author

The procedure seems to be to handle sw.js manually.

@YerkoPalma
Copy link
Member

YerkoPalma commented Feb 5, 2018

The procedure is to handle semver in package.json file. There is no direct version modification in sw.js file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants