Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a fully created app as reference #58

Open
tnguyen14 opened this issue Mar 15, 2018 · 5 comments
Open

Have a fully created app as reference #58

tnguyen14 opened this issue Mar 15, 2018 · 5 comments

Comments

@tnguyen14
Copy link
Contributor

I think it would be useful to have a completely set up project from scratch using create-choo-app included in this repo as a reference. Sometimes, I want to see what a conventionally set up choo app would look like, and cherry pick some features that would make sense for me. I think this is most applicable to an existing project.

@chrisdwheatley
Copy link
Contributor

I like the idea of having a reference for those interested in seeing how create-choo-app structures things.

We could easily add an example under an example directory in this repo and call it out in the readme, my only concern would be ensuring it's kept up to date as things change.

Am I along the right lines with what you were suggesting @tnguyen14?

@tnguyen14
Copy link
Contributor Author

Yes, that's exactly right.

I agree that it should be kept up to date as things change. Along that line, perhaps we can have a script to automatically update that directory with the latest example when changes are made?

@chrisdwheatley
Copy link
Contributor

It might be worth referencing the example in the main Choo repo (https://github.com/choojs/choo/tree/master/example) and then ensuring that create-choo-app represents the same structure.

@tnguyen14
Copy link
Contributor Author

Yeah, I agree with that. Need to consider one as the source of truth, and update the other. In this case, it might be easier to consider create-choo-app to be that source, and as part of the build process, somehow submit a PR against the main choo repo to update the example directory?

@ungoldman
Copy link
Member

Might be easier to just link to the single source of truth rather than maintaining a copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants