Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are un-commented #109

Open
ghost opened this issue Dec 11, 2018 · 4 comments
Open

Comments are un-commented #109

ghost opened this issue Dec 11, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Dec 11, 2018

It's late at night, so I'll keep this short.
I'm making a framework that uses nanomorph heavily. I've just been playing with it, and I realized that comments are uncommented, meaning the <!-- and --> are removed. This is a bit annoying when debugging my app. Not urgent, but just letting you know it's there.

@JRJurman
Copy link

@def0x099 can you clarify exactly what's happening, and maybe include some example code? Chances are you aren't using nanomorph in isolation, so it could be how you are building your DOM that is causing the issue.

@goto-bus-stop
Copy link
Member

Doing <!-- ${somevalue} abc --> could cause "abc" to end up in the html. it has recently been fixed in nanohtml. may that have been the cause?

@ghost
Copy link
Author

ghost commented Mar 23, 2019

Might be. This needs a repro tho.

@bennlich
Copy link

Sounds related to #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants