Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase better-sqlite3 compatibility #751

Closed
stephtr opened this issue Dec 23, 2023 · 1 comment
Closed

Increase better-sqlite3 compatibility #751

stephtr opened this issue Dec 23, 2023 · 1 comment

Comments

@stephtr
Copy link

stephtr commented Dec 23, 2023 •
edited

Is it possible to bump the better-sqlite3 requirement of @miniflare/shared to 9.x.x? There are some issues with better-sqlite3@8.x.x on Node 20 (most recent LTS), see WiseLibs/better-sqlite3#1100 or WiseLibs/better-sqlite3#1027, while I didn't notice any adverse effects when upgrading to 9.x.x. The only breaking change should be drop of official support for Node 16, which is EOL.
@mrbbot
Copy link
Contributor

mrbbot commented Jan 4, 2024 •
edited

Hey! 👋 Thanks for raising this. Unfortunately, as better-sqlite3@9.0.0 drops support for Node 16, upgrading to this would be a semver major breaking change for Miniflare 2. Considering we're planning to deprecate Miniflare 2 soon once we have support for the Vitest unit testing environment in version 3, I don't think we'll do this. I'd encourage you to migrate to Miniflare 3 if you can.

@mrbbot mrbbot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
workers-sdk
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephtr @mrbbot