Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineCountBear fails for symbolic links #2950

Open
jayvdb opened this issue Aug 22, 2019 · 2 comments
Open

LineCountBear fails for symbolic links #2950

jayvdb opened this issue Aug 22, 2019 · 2 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Aug 22, 2019

In projects repo

data/locale/en/projects/README.md

**** LineCountBear [Section: linecount | Severity: NORMAL] ****

!    ! This file has 0 lines, while 1 lines are required.

[WARNING][03:28:48] LineCountBear: This result has no patch attached.

_projects/README.md

**** LineCountBear [Section: linecount | Severity: NORMAL] ****

!    ! This file has 0 lines, while 1 lines are required.
@jayvdb
Copy link
Member Author

jayvdb commented Aug 22, 2019

This became a problem because of #1477 .

The error is actually truthful as the files do have zero lines, but it is misleading/confusing.

The justification in #1477 for a non-zero default is reasonable -- even though it is a change of behaviour from the previous release. While this is a regression, it is a by-product. Rather than change the default, and loose the benefits of it, fixing the handling of symlinks resolves the regression.

Skipping symlinks should be a feature of coala core, not separately built into each bear, so this needs to be upstreamed to coala core.

(There are also other very critical problems with symlinks in coala core, and probably issue already created)

@jayvdb jayvdb self-assigned this Aug 22, 2019
@jayvdb jayvdb reopened this Aug 22, 2019
@MaskedCarrot
Copy link

hello,
I want to work on this issue but I am new to open source can someone please guide me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants