Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Green Mode MP CPU problem on CI #295

Open
jayvdb opened this issue Aug 15, 2018 · 1 comment
Open

Green Mode MP CPU problem on CI #295

jayvdb opened this issue Aug 15, 2018 · 1 comment
Assignees
@jayvdb
Labels
type/bug type/tests

Comments

@jayvdb
Copy link
Member

jayvdb commented Aug 15, 2018 •
edited

The final version of the green mode caused CI problems.

  • MP had to be disabled on Windows
  • MP was failing badly on Python 3.5, and failing averagely on Python 3.4.

Increasing timeouts only led to memory exhaustion.
@jayvdb jayvdb self-assigned this Aug 15, 2018
jayvdb added a commit to jayvdb/coala-quickstart that referenced this issue Aug 15, 2018
@jayvdb
green_mode: Choose job count based on environment
b3cf751 
Python 3.4 and 3.5 fail under our pytest configuration
when the number of jobs is the cpu count - 1.
On Python 3.4, an extra cpu needs to be reserved for the tests
to operate smoothly on CI, and on Python 3.5 and Windows,
multiprocessing needs to be disabled entirely.

Expose argument jobs throughout green_mode, so that it
can be also exposed to the user or test suite for more
controlled use and testing.

Related to coala#295
@jayvdb jayvdb mentioned this issue Aug 15, 2018
Merged
jayvdb added a commit to jayvdb/coala-quickstart that referenced this issue Aug 15, 2018
@jayvdb
green_mode: Choose job count based on environment
8d82a81 
Python 3.4 and 3.5 fail under our pytest configuration
when the number of jobs is the cpu count - 1.
On Python 3.4, an extra cpu needs to be reserved for the tests
to operate smoothly on CI, and on Python 3.5 and Windows,
multiprocessing needs to be disabled entirely.

Expose argument jobs throughout green_mode, so that it
can be also exposed to the user or test suite for more
controlled use and testing.

Related to coala#295
jayvdb added a commit to jayvdb/coala-quickstart that referenced this issue Aug 15, 2018
@jayvdb
green_mode: Choose job count based on environment
01cda10 
Python 3.4 and 3.5 fail under our pytest configuration
when the number of jobs is the cpu count - 1.
On Python 3.4, an extra cpu needs to be reserved for the tests
to operate smoothly on CI, and on Python 3.5 and Windows,
multiprocessing needs to be disabled entirely.

Expose argument jobs throughout green_mode, so that it
can be also exposed to the user or test suite for more
controlled use and testing.

Related to coala#295
jayvdb added a commit to jayvdb/coala-quickstart that referenced this issue Aug 15, 2018
@jayvdb
green_mode: Choose job count based on environment
a4ccaf6 
Python 3.4 and 3.5 fail under our pytest configuration
when the number of jobs is the cpu count - 1.
On Python 3.4, an extra cpu needs to be reserved for the tests
to operate smoothly on CI, and on Python 3.5 and Windows,
multiprocessing needs to be disabled entirely.

Expose argument jobs throughout green_mode, so that it
can be also exposed to the user or test suite for more
controlled use and testing.

Related to coala#295
jayvdb added a commit to jayvdb/coala-quickstart that referenced this issue Aug 15, 2018
@jayvdb
green_mode: Choose job count based on environment
be9bd4a 
Python 3.4 and 3.5 fail under our pytest configuration
when the number of jobs is the cpu count - 1.
On Python 3.4, an extra cpu needs to be reserved for the tests
to operate smoothly on CI, and on Python 3.5 and Windows,
multiprocessing needs to be disabled entirely.

Expose argument jobs throughout green_mode, so that it
can be also exposed to the user or test suite for more
controlled use and testing.

Related to coala#295
jayvdb added a commit to jayvdb/coala-quickstart that referenced this issue Aug 16, 2018
@jayvdb
green_mode: Choose job count based on environment
4e80186 
Python 3.4 and 3.5 fail under our pytest configuration
when the number of jobs is the cpu count - 1.
On Python 3.4, an extra cpu needs to be reserved for the tests
to operate smoothly on CI, and on Python 3.5 and Windows,
multiprocessing needs to be disabled entirely.

Expose argument jobs throughout green_mode, so that it
can be also exposed to the user or test suite for more
controlled use and testing.

Related to coala#295
@ishanSrt
Copy link
Contributor

ishanSrt commented Oct 13, 2018 •
edited

Due to reasons I can't point out why

and failing averagely on Python 3.

it seems to be never green for python3.4 for the past many builds

jayvdb added a commit to jayvdb/coala-quickstart that referenced this issue Jun 19, 2019
@jayvdb
green_mode.py: Remove cpu reservation on py34
1c83c1c 
The cpu reservation was needed due to pytest-xdist being
installed, even though it wasnt activated.

Relates to coala#295
@jayvdb jayvdb mentioned this issue Jun 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayvdb jayvdb

Labels
type/bug type/tests
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayvdb @gitmate-bot @ishanSrt