Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cohesive Editor Support: update related issues #652

Open
jayvdb opened this issue Aug 24, 2018 · 4 comments
Open

Cohesive Editor Support: update related issues #652

jayvdb opened this issue Aug 24, 2018 · 4 comments
Assignees
@RohanVB
Labels
Project Proposal

Comments

@jayvdb
Copy link
Member

jayvdb commented Aug 24, 2018

coala/coala-eclipse#25 is closed.

coala/coala-eclipse#51 should be mentioned instead

coala/coala-emacs#11 is also closed, and should be simply removed.

The body of the project says

For VI and emacs, we will most likely use a testing framework such as Vimcasts.

emacs should be removed as testing for it was implemented.
@rahuldkjain
Copy link

Please assign this issue to me

rahuldkjain added a commit to rahuldkjain/projects that referenced this issue Aug 25, 2018
@rahuldkjain
editor_support: Removed emacs
d7db599 
coala/coala-eclipse#25 is replaced with coala/coala-eclipse#51.
coala/coala-emacs#11 is removed. emacs from the project body is also
removed.

Fixes coala#652
@rahuldkjain rahuldkjain mentioned this issue Aug 25, 2018
Closed
rahuldkjain pushed a commit to rahuldkjain/projects that referenced this issue Aug 26, 2018
editor_support: Removed emacs
6661374 
coala/coala-eclipse#25 is replaced with coala/coala-eclipse#51.
coala/coala-emacs#11 is removed. emacs from the project body is also
removed.

Fixes coala#652
@rahuldkjain rahuldkjain mentioned this issue Aug 26, 2018
Closed
@Naveenaidu
Copy link
Member

Naveenaidu commented Aug 26, 2018 •
edited

@rahuldkjain Please do not close the Pull Request. You are never supposed to do that. And please open only one PR for one issue.

In your case you could have just checked out to the branch rahuldkjain-patch-1 and made the changes there instead of making a new branch. And just squashed the commit as @srivama mentioned.

Please refer to the coala Newcomer guide.

rahuldkjain pushed a commit to rahuldkjain/projects that referenced this issue Aug 26, 2018
editor_support.md: Remove emacs
168bfb0 
coala/coala-eclipse#25 is replaced with coala/coala-eclipse#51.
coala/coala-emacs#11 is removed. emacs from the project body is also
removed.

Fixes coala#652
rahuldkjain pushed a commit to rahuldkjain/projects that referenced this issue Aug 26, 2018
editor_support.md: Remove emacs and Change coala/coala-eclipse#25
7e483a7 
coala/coala-eclipse#25 is replaced with coala/coala-eclipse#51.
coala/coala-emacs#11 is removed. emacs from the project body is also
removed.

Closes coala#652
rahuldkjain pushed a commit to rahuldkjain/projects that referenced this issue Aug 30, 2018
editor_support.md: Remove emacs and Change coala/coala-eclipse#25
d7ab0cd 
coala/coala-eclipse#25 is changed to coala/coala-eclipse#51.
coala/coala-emacs#11 is removed. "emacs" from the project body is also
removed.

Closes coala#652
rahuldkjain pushed a commit to rahuldkjain/projects that referenced this issue Oct 24, 2018
editor_support.md: Remove emacs and change issue
c327657 
"emacs" and coala/coala-emacs#11 is removed as testing for it
was implemented.
Changes from coala/coala-eclipse#25 --> coala/coala-eclipse#51

closes coala#652
@jayvdb jayvdb assigned RohanVB and unassigned rahuldkjain Aug 25, 2019
@jayvdb
Copy link
Member Author

jayvdb commented Aug 25, 2019

@RohanVB, do you feel these changes are useful to your project description? If not, we can just close this.

@RohanVB
Copy link
Member

RohanVB commented Aug 25, 2019

@RohanVB, do you feel these changes are useful to your project description? If not, we can just close this.

Not useful to my project description, no, but I can still address coala/coala-eclipse#51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RohanVB RohanVB

Labels
Project Proposal
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editor_support.md: Remove emacs and Change coala/coala-eclipse#25 rahuldkjain/projects
5 participants
@jayvdb @RohanVB @rahuldkjain @Naveenaidu @abhishalya