Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corobo Integration,Security and Enhancements. #688

Open
sladyn98 opened this issue Nov 7, 2018 · 12 comments · May be fixed by #727
Open

Corobo Integration,Security and Enhancements. #688

sladyn98 opened this issue Nov 7, 2018 · 12 comments · May be fixed by #727

Comments

@sladyn98
Copy link

sladyn98 commented Nov 7, 2018

Potential Mentor: @nvzard @Vamshi99
Integration

  1. Corobo can be used to display the status of the Continuous Integration services on the private chatroom in gitter and display the SPF (Single Point of Failure) on the chat.
    Rebuild CIs using corobo corobo#190.
  2. Leverage of corobo's current architecture to build commits from the chat itself:
    corobo rebuild travis|circle|appveyor <PR number>.
  3. Display status of builds of current PR numbers using fixed commands:
    corobo status travis|circle|appveyor <PR number>.
  4. Suggestion of newcomer issues for ease of selection.

Security

  1. We could possible seperate out the major modules of corobo as different microservices which could avoid the single point of failure that corobo is so exposed to right now.

Implementation Details:
Trigger Travis CI builds using the API V3 by sending a POST request to /repo/{slug|id}/requests:
This can be leveraged in building the project.

@jayvdb
Copy link
Member

jayvdb commented Nov 11, 2018

This is an odd assortment of issues. Please provide more clarity on the goal of the project proposal.

Random features are not a GSoC project.

@sladyn98
Copy link
Author

sladyn98 commented Nov 11, 2018 via email

@jayvdb
Copy link
Member

jayvdb commented Nov 11, 2018

Add more comments here, and discuss with potential mentors on gitter.

@sladyn98
Copy link
Author

Can you suggest any potential mentors or any feedback?

@jayvdb
Copy link
Member

jayvdb commented Nov 11, 2018

You should be able to determine who the potential mentors are. If not, you have not done enough work on developing your idea.

@sladyn98
Copy link
Author

sladyn98 commented Feb 1, 2019

As per his consent and agreement I have tagged @nvzard as a potential mentor for this project.

@nvzard
Copy link
Member

nvzard commented Apr 1, 2019

Possible ideas. Maybe these implementations plus ideas by students can be a potential project.
cc @meetmangukiya @Vamshi99

@sladyn98
Copy link
Author

sladyn98 commented Apr 1, 2019

  • Delegated authentication so that users can open issues via their own username ,perhaps we would need to store their personal access tokens or either make corobo an Oauth Application. Would need your thoughts on it..
    @nvzard @Vamshi99 @meetmangukiya

@sladyn98
Copy link
Author

sladyn98 commented Apr 1, 2019

@nvzard When opening an issue on the projects page could you separate it into security features and enhancements.

@sladyn98
Copy link
Author

sladyn98 commented Apr 1, 2019

@abhishalya your inputs would be highly valuable as well 👍

@meetmangukiya
Copy link
Member

What are the upsides of doing this? Just because the user who opened the issue becomes the owner of the issue..? Not a good enough reason to implement the whole OAuth flow, and if it is through personal access tokens, I guess those maybe possible, but those are more manual steps on user sides and not such a good UX. Anyways, we still need a good enough reason to do this I guess.

nvzard added a commit to nvzard/projects that referenced this issue Apr 1, 2019
@nvzard nvzard linked a pull request Apr 1, 2019 that will close this issue
2 tasks
nvzard added a commit to nvzard/projects that referenced this issue Apr 1, 2019
nvzard added a commit to nvzard/projects that referenced this issue Apr 1, 2019
nvzard added a commit to nvzard/projects that referenced this issue Apr 1, 2019
@sladyn98
Copy link
Author

sladyn98 commented Apr 2, 2019

cc : @Makman2 @nvzard @Vamshi99
Security Hardening:
a) Make the ACL plugin more extensible allowing custom acess control features.
b) Diabling autoinvite instead placing invites in a queue for maintainers to approve.
c) Many of the commands have a low test coverage, maximising test coverage for them
Enhancements:
(IGITT Enhancements)
a) Adapt LabHub plugin to use the most recent release of iGitt.
b) Deprecate use of github3 and migrate plugins to use iGitt.
(GCI Improvements)
During the period of GCI, we need to block assignments of all “area/gci initiative” tagged issues from all coala repos.

  1. We need to create a new team called “GCI members” and invite all GCI students.
  2. Then, grant access of assignments of “area/gci initiative” tagged issues to GCI members team
  3. create a new plugin “current event”, which mentions the current event going on

Features:
a) Find a way to handle a person with a different GitHub and GitLab usernames.
b) Running auto builds on travis ci and checking their status on github via a status CI #PRnumber
c) Vote Plugin
d) Command for low effort questions coala/corobo#314
e) Corobo stats plugin to show how cool out bot is :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants