Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: pg_regress failed #124381

Open
cockroach-teamcity opened this issue May 18, 2024 · 3 comments
Open

roachtest: pg_regress failed #124381

cockroach-teamcity opened this issue May 18, 2024 · 3 comments
Labels
branch-master Failures on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. P-3 Issues/test failures with no fix SLA T-sql-queries SQL Queries Team

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 18, 2024

roachtest.pg_regress failed with artifacts on master @ 93ad913106b6f0f6ec98bc2cfa788ff6d8085bd4:

    RETURN NULL;
  END;
  $$;
@@ -239345,7 +240368,7 @@
  --
  -- Test multiple reference to a transition table
  --
-@@ -5761,22 +6524,45 @@
+@@ -5761,22 +6550,45 @@
         FROM (SELECT * FROM new_test UNION ALL SELECT * FROM new_test) ss);
      RETURN NULL;
  END$$;
@@ -239393,7 +240416,7 @@
  CREATE OR REPLACE FUNCTION get_from_partitioned_table(partitioned_table.a%type)
  RETURNS partitioned_table AS $$
  DECLARE
-@@ -5787,13 +6573,13 @@
+@@ -5787,13 +6599,13 @@
      SELECT * INTO result FROM partitioned_table WHERE a = a_val;
      RETURN result;
  END; $$ LANGUAGE plpgsql;
@@ -239413,7 +240436,7 @@
  CREATE OR REPLACE FUNCTION list_partitioned_table()
  RETURNS SETOF partitioned_table.a%TYPE AS $$
  DECLARE
-@@ -5806,14 +6592,13 @@
+@@ -5806,14 +6618,13 @@
      END LOOP;
      RETURN;
  END; $$ LANGUAGE plpgsql;
@@ -239434,7 +240457,7 @@
  --
  -- Check argument name is used instead of $n in error message
  --
-@@ -5822,6 +6607,15 @@
+@@ -5822,6 +6633,15 @@
    GET DIAGNOSTICS x = ROW_COUNT;
    RETURN;
  END; $$ LANGUAGE plpgsql;
@@ -265846,7 +266869,7 @@
 +       ^
 +HINT:  try \h CREATE
  create table rewriteme (id serial primary key, foo float, bar timestamptz);
-+NOTICE:  using sequential values in a primary key does not perform as well as using random UUIDs. See https://www.cockroachlabs.com/docs/v24.1/serial.html
++NOTICE:  using sequential values in a primary key does not perform as well as using random UUIDs. See https://www.cockroachlabs.com/docs/v24.2/serial.html
  insert into rewriteme
       select x * 1.001 from generate_series(1, 500) as t(x);
  alter table rewriteme alter column foo type numeric;
If the diff is expected, copy regression.diffs from the test artifacts to pkg/cmd/roachtest/testdata/regression.diffs
test artifacts and logs in: /artifacts/pg_regress/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=false
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

This test on roachdash | Improve this report!

Jira issue: CRDB-38856

@cockroach-teamcity cockroach-teamcity added branch-master Failures on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team labels May 18, 2024
@cockroach-teamcity
Copy link
Member Author

roachtest.pg_regress failed with artifacts on master @ b5081e997adaf5950c9b85dfb6655f226bf16d29:

    RETURN NULL;
  END;
  $$;
@@ -239345,7 +240378,7 @@
  --
  -- Test multiple reference to a transition table
  --
-@@ -5761,22 +6524,45 @@
+@@ -5761,22 +6550,45 @@
         FROM (SELECT * FROM new_test UNION ALL SELECT * FROM new_test) ss);
      RETURN NULL;
  END$$;
@@ -239393,7 +240426,7 @@
  CREATE OR REPLACE FUNCTION get_from_partitioned_table(partitioned_table.a%type)
  RETURNS partitioned_table AS $$
  DECLARE
-@@ -5787,13 +6573,13 @@
+@@ -5787,13 +6599,13 @@
      SELECT * INTO result FROM partitioned_table WHERE a = a_val;
      RETURN result;
  END; $$ LANGUAGE plpgsql;
@@ -239413,7 +240446,7 @@
  CREATE OR REPLACE FUNCTION list_partitioned_table()
  RETURNS SETOF partitioned_table.a%TYPE AS $$
  DECLARE
-@@ -5806,14 +6592,13 @@
+@@ -5806,14 +6618,13 @@
      END LOOP;
      RETURN;
  END; $$ LANGUAGE plpgsql;
@@ -239434,7 +240467,7 @@
  --
  -- Check argument name is used instead of $n in error message
  --
-@@ -5822,6 +6607,15 @@
+@@ -5822,6 +6633,15 @@
    GET DIAGNOSTICS x = ROW_COUNT;
    RETURN;
  END; $$ LANGUAGE plpgsql;
@@ -265846,7 +266879,7 @@
 +       ^
 +HINT:  try \h CREATE
  create table rewriteme (id serial primary key, foo float, bar timestamptz);
-+NOTICE:  using sequential values in a primary key does not perform as well as using random UUIDs. See https://www.cockroachlabs.com/docs/v24.1/serial.html
++NOTICE:  using sequential values in a primary key does not perform as well as using random UUIDs. See https://www.cockroachlabs.com/docs/v24.2/serial.html
  insert into rewriteme
       select x * 1.001 from generate_series(1, 500) as t(x);
  alter table rewriteme alter column foo type numeric;
If the diff is expected, copy regression.diffs from the test artifacts to pkg/cmd/roachtest/testdata/regression.diffs
test artifacts and logs in: /artifacts/pg_regress/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=false
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

This test on roachdash | Improve this report!

@mgartner
Copy link
Collaborator

mgartner commented Jun 5, 2024

I think we just need to change the NOTICE line from 24.1 to 24.2.

-+NOTICE:  using sequential values in a primary key does not perform as well as using random UUIDs. See https://www.cockroachlabs.com/docs/v24.1/serial.html
++NOTICE:  using sequential values in a primary key does not perform as well as using random UUIDs. See https://www.cockroachlabs.com/docs/v24.2/serial.html

@mgartner mgartner added the P-3 Issues/test failures with no fix SLA label Jun 5, 2024
@cockroach-teamcity
Copy link
Member Author

roachtest.pg_regress failed with artifacts on master @ c7f37e813dbd1e6d2afdb88c5e9cd986dc061299:

+@@ -5761,22 +6553,45 @@
         FROM (SELECT * FROM new_test UNION ALL SELECT * FROM new_test) ss);
      RETURN NULL;
  END$$;
@@ -239393,7 +240431,7 @@
  CREATE OR REPLACE FUNCTION get_from_partitioned_table(partitioned_table.a%type)
  RETURNS partitioned_table AS $$
  DECLARE
-@@ -5787,13 +6573,13 @@
+@@ -5787,13 +6602,13 @@
      SELECT * INTO result FROM partitioned_table WHERE a = a_val;
      RETURN result;
  END; $$ LANGUAGE plpgsql;
@@ -239413,7 +240451,7 @@
  CREATE OR REPLACE FUNCTION list_partitioned_table()
  RETURNS SETOF partitioned_table.a%TYPE AS $$
  DECLARE
-@@ -5806,14 +6592,13 @@
+@@ -5806,14 +6621,13 @@
      END LOOP;
      RETURN;
  END; $$ LANGUAGE plpgsql;
@@ -239434,7 +240472,7 @@
  --
  -- Check argument name is used instead of $n in error message
  --
-@@ -5822,6 +6607,15 @@
+@@ -5822,6 +6636,16 @@
    GET DIAGNOSTICS x = ROW_COUNT;
    RETURN;
  END; $$ LANGUAGE plpgsql;
@@ -239442,6 +240480,7 @@
 -LINE 3:   GET DIAGNOSTICS x = ROW_COUNT;
 -                          ^
 +ERROR:  unimplemented: attempted to use a PL/pgSQL statement that is not yet supported
++DETAIL:  stmt_get_diag is not yet supported
 +HINT:  You have attempted to use a feature that is not yet implemented.
 +
 +Please check the public issue tracker to check whether this problem is
@@ -265846,7 +266885,7 @@
 +       ^
 +HINT:  try \h CREATE
  create table rewriteme (id serial primary key, foo float, bar timestamptz);
-+NOTICE:  using sequential values in a primary key does not perform as well as using random UUIDs. See https://www.cockroachlabs.com/docs/v24.1/serial.html
++NOTICE:  using sequential values in a primary key does not perform as well as using random UUIDs. See https://www.cockroachlabs.com/docs/v24.2/serial.html
  insert into rewriteme
       select x * 1.001 from generate_series(1, 500) as t(x);
  alter table rewriteme alter column foo type numeric;
If the diff is expected, copy regression.diffs from the test artifacts to pkg/cmd/roachtest/testdata/regression.diffs
test artifacts and logs in: /artifacts/pg_regress/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=false
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

This test on roachdash | Improve this report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. P-3 Issues/test failures with no fix SLA T-sql-queries SQL Queries Team
Projects
Status: Triage
Development

No branches or pull requests

2 participants