Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep CodeRoad webview on top #198

Open
ShMcK opened this issue Apr 5, 2020 · 2 comments
Open

Keep CodeRoad webview on top #198

ShMcK opened this issue Apr 5, 2020 · 2 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@ShMcK
Copy link
Member

ShMcK commented Apr 5, 2020

There are times where the webview falls behind other editor views.

Solutions for this include:

  1. waiting for VSCode to allow webviews in the side panel
  2. listening to editor changes and triggering the webview to jump back on top. This may be annnoying
  3. determining times when CodeRoad triggers the webview into the background and triggering a fix for these. It's really only an issue when the webview hides its self due to loaded files in the workspace.

I'm thinking 3 may be a good strategy. 1 can be considered in the future.

@ShMcK ShMcK added the bug Something isn't working label Apr 5, 2020
@ShMcK ShMcK added this to To do in Feedback & Fixes Apr 6, 2020
@ShMcK ShMcK added this to the Stable Release milestone Apr 6, 2020
@ShMcK ShMcK self-assigned this Apr 6, 2020
@ShMcK ShMcK removed this from the Stable Release milestone Apr 11, 2020
@ShMcK ShMcK added this to To do in Extension May 15, 2020
@ShMcK ShMcK added the wontfix This will not be worked on label Aug 6, 2020
@ShMcK
Copy link
Member Author

ShMcK commented Aug 27, 2020

This seems to be possible in an upcoming version of VSCode, where webviews can be put into the main side panel (eg. where the git, extensions, etc live). The PR was merged last week.

@ShMcK
Copy link
Member Author

ShMcK commented Sep 13, 2020

Now available as a "Proposed API". https://code.visualstudio.com/updates/v1_49#_webview-views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
No open projects
Extension
  
To do
Development

No branches or pull requests

1 participant