Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variants #27

Open
tpaviot opened this issue May 15, 2024 · 2 comments
Open

variants #27

tpaviot opened this issue May 15, 2024 · 2 comments
Labels
question Further information is requested

Comments

@tpaviot
Copy link
Contributor

tpaviot commented May 15, 2024

Comment:

Alghouth occt is available in both vtk and notvtk versions, which makes sense, pythonocc doesn't wrap the vtk part of occt. As a consequence, there's no need to take the variants into account for pythonocc build, only the 'novtk' build should be performed.

@tpaviot tpaviot added the question Further information is requested label May 15, 2024
@Krande
Copy link
Contributor

Krande commented May 27, 2024

Hey @tpaviot!

Your point is definitively valid as the build matrix is quite big when compiling against both variants.

The reason for compiling pythonocc-core against both 'novtk' and 'all' variants of occt was to provide an alternative for anyone who wants to use pythonocc-core AND that directly or indirectly through other packages might rely on the VTK compilation options of occt.

In hindsight I've come to think that my assumption about the number of users that need the VTK capabilities in occt AND also uses pythonocc-core might be unfounded. And if these options are needed, it might be better to rely on self-compiled packages in a dedicated anaconda channel.

If @looooo agrees, then I would support limiting the next release of pythonocc-core to just the 'novtk' variant.

@tpaviot
Copy link
Contributor Author

tpaviot commented May 28, 2024

@Krande I understand your point of view, after opening this issue I realized some users might need to download the vtk pythonocc variant if ever occt-vtk is already used by another package. That makes sense. If the "no vtk variant" is kept as default, then it's ok, no need to change anything to the build matrix, unless you're concerned with energy consumption on the azure cloud side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants