Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of GPL lbraries (readline, gsl) #2

Open
isuruf opened this issue Feb 14, 2021 · 6 comments · Fixed by #3
Open

Remove the use of GPL lbraries (readline, gsl) #2

isuruf opened this issue Feb 14, 2021 · 6 comments · Fixed by #3

Comments

@isuruf
Copy link
Member

isuruf commented Feb 14, 2021

I didn't see this at the code review, but ZIB and GPL don't go together. So, please remove GPL dependencies. This issue is mentioned in https://www.scipopt.org/index.php#license.

cc @conda-forge/core

@AntoinePrv AntoinePrv linked a pull request Feb 22, 2021 that will close this issue
5 tasks
@AntoinePrv
Copy link
Contributor

Thanks for pointing this out @isuruf. Does it change anything if the libraries are linked dynamically?

@AntoinePrv
Copy link
Contributor

@isuruf actually, gsl is used only in for the gcg subpackage, which is licensed under LGPL
https://gcg.or.rwth-aachen.de/#license

But it is not possible to have licenses for outputs in conda-build. We can add again gsl and package the LGPL license for gcg.

@AntoinePrv AntoinePrv reopened this Feb 23, 2021
@isuruf
Copy link
Member Author

isuruf commented Feb 23, 2021

gsl is used only in for the gcg subpackage, which is licensed under LGPL

But gcg has scip as a dependency right?

@AntoinePrv
Copy link
Contributor

Yes. Would that prevent it from from using LGPL dependencies?

Python itself seems to be using readline, would that mean it's forbidden to distribute proprietary native Python packages?
I argree we should not link SCIP with readline, but in the case of gcg with gsl it does not seem so clear to me.

@AntoinePrv
Copy link
Contributor

AntoinePrv commented Feb 23, 2021

Or perhaps, looking at it the other way, we could ask the ZIB team the licensing more details about the implications to dynamically link against scip.

@isuruf
Copy link
Member Author

isuruf commented Feb 24, 2021

Yes. Would that prevent it from from using LGPL dependencies?

IANAL, so can't say it does or not. To be on the safe side we could remove GSL.

cc @conda-forge/core

AntoinePrv added a commit to AntoinePrv/fork-conda-forge-scipoptsuite-feedstock that referenced this issue Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants